From 7dc5c28d430f26f087711b1208f876fa2d530d5b Mon Sep 17 00:00:00 2001 From: Vinay Mistry Date: Mon, 17 Oct 2022 12:22:19 +0100 Subject: [PATCH 1/3] Valuation schema update due to a misspelling --- CHANGELOG.md | 1 + src/context/schemas/valuation.schema.json | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6da619edf..a9d7d5143 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -96,6 +96,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). * Updated Methods.ts to support the updated signature for `addContextListener` introduced in FDC3 1.2 ([#462](https://github.com/finos/FDC3/pull/462)) * Clarified the description of the addContextListener functions from the Desktop Agent and Channel APIs in spec and docs. ([#492](https://github.com/finos/FDC3/pull/492)) * Clarified that implementing `fdc3.getInfo()` is required for compliance with the FDC3 standard ([#515](https://github.com/finos/FDC3/pull/515)) +* Corrected syntax errors in valuation schema ([#XXX](https://github.com/finos/FDC3/pull/XXX)) ## [npm v1.2.0] - 2021-04-19 diff --git a/src/context/schemas/valuation.schema.json b/src/context/schemas/valuation.schema.json index e34dedfc9..e9a2f57ba 100644 --- a/src/context/schemas/valuation.schema.json +++ b/src/context/schemas/valuation.schema.json @@ -8,7 +8,7 @@ "type": { "const": "fdc3.valuation" }, "value": { "type": "number" }, "price": { "type": "number"}, - "CURRENCY_ISCODE": { "type": "string", "pattern": "^[A-Z]{3}$" }, + "CURRENCY_ISOCODE": { "type": "string", "pattern": "^[A-Z]{3}$" }, "valuationTime": {"type": "string", "format": "date-time" }, "expiryTime": {"type": "string", "format": "date-time" } }, From e9079e5ec31f3b3401959795db8996929d3c3911 Mon Sep 17 00:00:00 2001 From: Vinay Mistry Date: Mon, 17 Oct 2022 12:27:14 +0100 Subject: [PATCH 2/3] Updateed changelog.md with correct PR number --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index a9d7d5143..d37c2fa5f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -96,7 +96,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). * Updated Methods.ts to support the updated signature for `addContextListener` introduced in FDC3 1.2 ([#462](https://github.com/finos/FDC3/pull/462)) * Clarified the description of the addContextListener functions from the Desktop Agent and Channel APIs in spec and docs. ([#492](https://github.com/finos/FDC3/pull/492)) * Clarified that implementing `fdc3.getInfo()` is required for compliance with the FDC3 standard ([#515](https://github.com/finos/FDC3/pull/515)) -* Corrected syntax errors in valuation schema ([#XXX](https://github.com/finos/FDC3/pull/XXX)) +* Corrected syntax errors in valuation schema ([#834](https://github.com/finos/FDC3/pull/834)) ## [npm v1.2.0] - 2021-04-19 From f30b08e199f418133c2480796737bc4879ac1f3a Mon Sep 17 00:00:00 2001 From: Kris West Date: Tue, 25 Oct 2022 15:01:20 +0100 Subject: [PATCH 3/3] Update valuation.schema.json fix typo in 2.0 version of schema --- website/static/schemas/2.0/valuation.schema.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/website/static/schemas/2.0/valuation.schema.json b/website/static/schemas/2.0/valuation.schema.json index f2f0e5355..4aa1d7cd9 100644 --- a/website/static/schemas/2.0/valuation.schema.json +++ b/website/static/schemas/2.0/valuation.schema.json @@ -8,7 +8,7 @@ "type": { "const": "fdc3.valuation" }, "value": { "type": "number" }, "price": { "type": "number"}, - "CURRENCY_ISCODE": { "type": "string", "pattern": "^[A-Z]{3}$" }, + "CURRENCY_ISOCODE": { "type": "string", "pattern": "^[A-Z]{3}$" }, "valuationTime": {"type": "string", "format": "date-time" }, "expiryTime": {"type": "string", "format": "date-time" } },