Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDA-3596 (Set the bounds for newly created child window) #1359

Merged
merged 1 commit into from
Feb 28, 2022
Merged

SDA-3596 (Set the bounds for newly created child window) #1359

merged 1 commit into from
Feb 28, 2022

Conversation

KiranNiranjan
Copy link
Member

@KiranNiranjan KiranNiranjan commented Feb 25, 2022 •
edited
Loading

Description

  • Electron is no longer setting the bounds for the newly created child bounds
  • Manually set the bounds for newly created child window on start-loading

Related PRs

@KiranNiranjan KiranNiranjan self-assigned this Feb 25, 2022
@KiranNiranjan KiranNiranjan mentioned this pull request Feb 25, 2022
Merged
@KiranNiranjan KiranNiranjan merged commit f65421d into finos:main Feb 28, 2022
@KiranNiranjan KiranNiranjan deleted the SDA-3596 branch February 28, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keerthi16 keerthi16 keerthi16 approved these changes

@sbenmoussati sbenmoussati sbenmoussati approved these changes

Assignees

@KiranNiranjan KiranNiranjan

Labels
14.1.x 🐛 bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KiranNiranjan @keerthi16 @sbenmoussati