electron-145: fixes the issue with invalid json config upon repair #195
Conversation
|
Any idea how i can get |
|
As per @maoo, we are already whitelisted for cla. So, not sure why it's failing. |
|
Checking logs now; I can confirm that @VishwasShashidhar has a signed CLA and this is a bot failure; @VikasShashidhar @lneir - from an IP standpoint - you can safely merge this PR; I'll investigate this and keep you posted. |
|
@VishwasShashidhar , could you please check if your email address is associated with your Github profile? You can read more on octokit/octokit.net#1433 (comment) ; this may be the cause of the issue with cla-bot. Thanks! |
|
@maoo Thanks. |
|
LGTM 👍 |
|
@maoo Thanks! You were right. I had forgotten adding my symphony email id, it should work now. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
Fixes an issue where upon using the "Repair" option with the Symphony installer, the unselected config was getting wiped out and that resulted in an invalid JSON config file. (i.e. Global Symphony config).
Solution
Advanced Installer allows us to have a configuration to specify not to overwrite certain files during reinstallation. The trick is to restrict this to only the reinstall (repair) case. Without that condition, the specific set of files are left untouched during uninstallation as well.
Anyway, this PR should fix our problem.
@lneir @VikasShashidhar Please review.