Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Red Hat OpenShift Container Platform Service Approval Accelerator #97

Closed
wants to merge 10 commits into from

Conversation

@J0EG
Copy link

@J0EG J0EG commented Feb 10, 2021

Pull Request for initial Contribution

@finos-cla-bot
Copy link

@finos-cla-bot finos-cla-bot bot commented Feb 10, 2021

Thank you for your contribution and Welcome to our Open Source Community!

To make sure your pull request is successful, we need all our contributors to be identifiable, but we couldn't parse the GitHub details of the following people : Joe Gordano

Luckily, resolving the issue is straightforward and you can resolve it by following the instructions below.

  1. Check your git client is configured with a user email git config --list | grep email
  2. If the user email is missing, run the following command, substituting with your git commit email address git config --global user.email email@example.com
  3. Make sure your git commit email is configured on GitHub by Setting your Commit Email Address
  4. Then, amend the authors in your commit history by using git commit --amend to change your last commit.

Alternatively, use the slightly more complex git reset --soft and git rebase to checkout your changes, rewrite the commit history locally and (force) push changes to the downstream branch.

If you have any issues with the steps above, please email help@finos.org so we can help you resolve before reviewing and accepting your pull request.

Thanks once again for the contribution and understanding.

cc @finos-admin

@mcleo-d mcleo-d changed the title Initial Commit - Joe G - 02/10/2021 Red Hat OpenShift Container Platform Service Approval Accelerator Feb 10, 2021
@mcleo-d mcleo-d added this to To do in Cloud Service Certification via automation Feb 10, 2021
@mcleo-d mcleo-d moved this from To do to In progress in Cloud Service Certification Feb 10, 2021
@mcleo-d mcleo-d mentioned this pull request Feb 25, 2021
4 tasks
</tr>

</tr>
<!--

This comment has been minimized.

@TLATER

TLATER Feb 25, 2021
Contributor

i imagine this is intended as a "preview"? Or is it accidentally left in?

It'd be nicest to have a comment to remove this before the PR is merged instead of leaving it as a comment, since this interferes with the markdown preview side of things, making the doc quite hard to review.

This comment has been minimized.

@J0EG

J0EG Apr 5, 2021
Author

Sorry for the late reply, I actually converted the format to Asciidoc and submitted subsequent pull requests.

@finos-cla-bot
Copy link

@finos-cla-bot finos-cla-bot bot commented Mar 8, 2021

Thank you for your contribution and Welcome to our Open Source Community!

To make sure your pull request is successful, we need all our contributors to be identifiable, but we couldn't parse the GitHub details of the following people : Joe Gordano

Luckily, resolving the issue is straightforward and you can resolve it by following the instructions below.

  1. Check your git client is configured with a user email git config --list | grep email
  2. If the user email is missing, run the following command, substituting with your git commit email address git config --global user.email email@example.com
  3. Make sure your git commit email is configured on GitHub by Setting your Commit Email Address
  4. Then, amend the authors in your commit history by using git commit --amend to change your last commit.

Alternatively, use the slightly more complex git reset --soft and git rebase to checkout your changes, rewrite the commit history locally and (force) push changes to the downstream branch.

If you have any issues with the steps above, please email help@finos.org so we can help you resolve before reviewing and accepting your pull request.

Thanks once again for the contribution and understanding.

cc @finos-admin

@finos-cla-bot
Copy link

@finos-cla-bot finos-cla-bot bot commented Mar 8, 2021

Thank you for your contribution and Welcome to our Open Source Community!

To make sure your pull request is successful, we need all our contributors to be identifiable, but we couldn't parse the GitHub details of the following people : Joe Gordano

Luckily, resolving the issue is straightforward and you can resolve it by following the instructions below.

  1. Check your git client is configured with a user email git config --list | grep email
  2. If the user email is missing, run the following command, substituting with your git commit email address git config --global user.email email@example.com
  3. Make sure your git commit email is configured on GitHub by Setting your Commit Email Address
  4. Then, amend the authors in your commit history by using git commit --amend to change your last commit.

Alternatively, use the slightly more complex git reset --soft and git rebase to checkout your changes, rewrite the commit history locally and (force) push changes to the downstream branch.

If you have any issues with the steps above, please email help@finos.org so we can help you resolve before reviewing and accepting your pull request.

Thanks once again for the contribution and understanding.

cc @finos-admin

@finos-cla-bot
Copy link

@finos-cla-bot finos-cla-bot bot commented Mar 8, 2021

Thank you for your contribution and Welcome to our Open Source Community!

To make sure your pull request is successful, we need all our contributors to be identifiable, but we couldn't parse the GitHub details of the following people : Joe Gordano

Luckily, resolving the issue is straightforward and you can resolve it by following the instructions below.

  1. Check your git client is configured with a user email git config --list | grep email
  2. If the user email is missing, run the following command, substituting with your git commit email address git config --global user.email email@example.com
  3. Make sure your git commit email is configured on GitHub by Setting your Commit Email Address
  4. Then, amend the authors in your commit history by using git commit --amend to change your last commit.

Alternatively, use the slightly more complex git reset --soft and git rebase to checkout your changes, rewrite the commit history locally and (force) push changes to the downstream branch.

If you have any issues with the steps above, please email help@finos.org so we can help you resolve before reviewing and accepting your pull request.

Thanks once again for the contribution and understanding.

cc @finos-admin

Updated Doc Links
@finos-cla-bot
Copy link

@finos-cla-bot finos-cla-bot bot commented Mar 11, 2021

Thank you for your contribution and Welcome to our Open Source Community!

To make sure your pull request is successful, we need all our contributors to be identifiable, but we couldn't parse the GitHub details of the following people : Joe Gordano

Luckily, resolving the issue is straightforward and you can resolve it by following the instructions below.

  1. Check your git client is configured with a user email git config --list | grep email
  2. If the user email is missing, run the following command, substituting with your git commit email address git config --global user.email email@example.com
  3. Make sure your git commit email is configured on GitHub by Setting your Commit Email Address
  4. Then, amend the authors in your commit history by using git commit --amend to change your last commit.

Alternatively, use the slightly more complex git reset --soft and git rebase to checkout your changes, rewrite the commit history locally and (force) push changes to the downstream branch.

If you have any issues with the steps above, please email help@finos.org so we can help you resolve before reviewing and accepting your pull request.

Thanks once again for the contribution and understanding.

cc @finos-admin

@mcleo-d mcleo-d moved this from In progress to To do in Cloud Service Certification Mar 26, 2021
@finos-cla-bot
Copy link

@finos-cla-bot finos-cla-bot bot commented May 4, 2021

Thank you for your contribution and Welcome to our Open Source Community!

To make sure your pull request is successful, we need all our contributors to be identifiable, but we couldn't parse the GitHub details of the following people : Joe Gordano

Luckily, resolving the issue is straightforward and you can resolve it by following the instructions below.

  1. Check your git client is configured with a user email git config --list | grep email
  2. If the user email is missing, run the following command, substituting with your git commit email address git config --global user.email email@example.com
  3. Make sure your git commit email is configured on GitHub by Setting your Commit Email Address
  4. Then, amend the authors in your commit history by using git commit --amend to change your last commit.

Alternatively, use the slightly more complex git reset --soft and git rebase to checkout your changes, rewrite the commit history locally and (force) push changes to the downstream branch.

If you have any issues with the steps above, please email help@finos.org so we can help you resolve before reviewing and accepting your pull request.

Thanks once again for the contribution and understanding.

cc @finos-admin

@mcleo-d
Copy link
Member

@mcleo-d mcleo-d commented May 13, 2021

Hi @J0EG - This is to confirm you have been added to the Red Hat CCLA and now need to update your local git settings so your commit records reflect the details be have at FINOS. I will reach out to your privately to align on these details.

#97 (comment)

@@ -0,0 +1,560 @@
# Detailed Security Configuration

This comment has been minimized.

@peter-thomas-db

peter-thomas-db May 18, 2021

Does this contain the same content as the asciidoc version? I skimmed it and it seems similar - if so we should delete one and keep one.

Copy link

@peter-thomas-db peter-thomas-db left a comment

This is a really good start. It would be even better if this document could be more opinionated in the configuration, take a look at the GKE equivalent for some guidance - for example around CMEK, encryption of etcd.d, workload isolation, certificates, etc.

@Ivan-Radovanovic
Copy link

@Ivan-Radovanovic Ivan-Radovanovic commented May 18, 2021

hello there

@finos-cla-bot
Copy link

@finos-cla-bot finos-cla-bot bot commented Jun 9, 2021

Thank you for your contribution and Welcome to our Open Source Community!

To make sure your pull request is successful, we need all our contributors to be identifiable, but we couldn't parse the GitHub details of the following people : Joe Gordano

Luckily, resolving the issue is straightforward and you can resolve it by following the instructions below.

  1. Check your git client is configured with a user email git config --list | grep email
  2. If the user email is missing, run the following command, substituting with your git commit email address git config --global user.email email@example.com
  3. Make sure your git commit email is configured on GitHub by Setting your Commit Email Address
  4. Then, amend the authors in your commit history by using git commit --amend to change your last commit.

Alternatively, use the slightly more complex git reset --soft and git rebase to checkout your changes, rewrite the commit history locally and (force) push changes to the downstream branch.

If you have any issues with the steps above, please email help@finos.org so we can help you resolve before reviewing and accepting your pull request.

Thanks once again for the contribution and understanding.

cc @finos-admin

@finos-cla-bot
Copy link

@finos-cla-bot finos-cla-bot bot commented Jun 9, 2021

Thank you for your contribution and Welcome to our Open Source Community!

To make sure your pull request is successful, we need all our contributors to be identifiable, but we couldn't parse the GitHub details of the following people : Joe Gordano

Luckily, resolving the issue is straightforward and you can resolve it by following the instructions below.

  1. Check your git client is configured with a user email git config --list | grep email
  2. If the user email is missing, run the following command, substituting with your git commit email address git config --global user.email email@example.com
  3. Make sure your git commit email is configured on GitHub by Setting your Commit Email Address
  4. Then, amend the authors in your commit history by using git commit --amend to change your last commit.

Alternatively, use the slightly more complex git reset --soft and git rebase to checkout your changes, rewrite the commit history locally and (force) push changes to the downstream branch.

If you have any issues with the steps above, please email help@finos.org so we can help you resolve before reviewing and accepting your pull request.

Thanks once again for the contribution and understanding.

cc @finos-admin

@finos-cla-bot
Copy link

@finos-cla-bot finos-cla-bot bot commented Jun 9, 2021

Thank you for your contribution and Welcome to our Open Source Community!

To make sure your pull request is successful, we need all our contributors to be identifiable, but we couldn't parse the GitHub details of the following people : Joe Gordano

Luckily, resolving the issue is straightforward and you can resolve it by following the instructions below.

  1. Check your git client is configured with a user email git config --list | grep email
  2. If the user email is missing, run the following command, substituting with your git commit email address git config --global user.email email@example.com
  3. Make sure your git commit email is configured on GitHub by Setting your Commit Email Address
  4. Then, amend the authors in your commit history by using git commit --amend to change your last commit.

Alternatively, use the slightly more complex git reset --soft and git rebase to checkout your changes, rewrite the commit history locally and (force) push changes to the downstream branch.

If you have any issues with the steps above, please email help@finos.org so we can help you resolve before reviewing and accepting your pull request.

Thanks once again for the contribution and understanding.

cc @finos-admin

@mcleo-d
Copy link
Member

@mcleo-d mcleo-d commented Jun 11, 2021

Hi @J0EG,

I have extended CSC Sprint 2 until 17th June '21 due to team member annual leave and have added this item to the #127 agenda to discuss in relation to completion and Sprint 3.

Cheers,

James 🚀

@J0EG
Copy link
Author

@J0EG J0EG commented Jun 11, 2021

@mcleo-d We will likely need to move this into the next sprint, we've made some progress regarding running probr against OpenShift and want to incorporate those into the re-developed Service Accelerator Template based on the review.

@J0EG
Copy link
Author

@J0EG J0EG commented Jun 11, 2021

Going to close this for now and reopen when we have a new update to the service accelerator template.

@J0EG J0EG closed this Jun 11, 2021
Cloud Service Certification automation moved this from In progress to Done Jun 11, 2021
@J0EG J0EG deleted the J0EG:master branch Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants