Skip to content

Conversation

@andypols
Copy link
Contributor

@andypols andypols commented Dec 5, 2025

Summary

This PR fixes a warning I see when running the app or the tests.

[1] ▲ [WARNING] The condition "types" here will never be used as it comes after both "import" and "require" [package.json]
[1] 
[1]     package.json:11:6:
[1]       11 │       "types": "./dist/index.d.ts"
[1]          ╵       ~~~~~~~
[1] 
[1]   The "import" condition comes earlier and will be used for all "import" statements:
[1] 
[1]     package.json:9:6:
[1]       9 │       "import": "./dist/index.js",
[1]         ╵       ~~~~~~~~
[1] 
[1]   The "require" condition comes earlier and will be used for all "require" calls:
[1] 
[1]     package.json:10:6:
[1]       10 │       "require": "./dist/index.js",
[1]          ╵       ~~~~~~~~~
[1] 
[1] ▲ [WARNING] The condition "types" here will never be used as it comes after both "import" and "require" [package.json]
[1] 
[1]     package.json:16:6:
[1]       16 │       "types": "./dist/src/config/index.d.ts"
[1]          ╵       ~~~~~~~
[1] 
[1]   The "import" condition comes earlier and will be used for all "import" statements:
[1] 
[1]     package.json:14:6:
[1]       14 │       "import": "./dist/src/config/index.js",
[1]          ╵       ~~~~~~~~
[1] 
[1]   The "require" condition comes earlier and will be used for all "require" calls:
[1] 
[1]     package.json:15:6:
[1]       15 │       "require": "./dist/src/config/index.js",
[1]          ╵       ~~~~~~~~~
[1] 

@netlify
Copy link

netlify bot commented Dec 5, 2025

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 4e80f93
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/6933cdbbf3e91a0008495736

@github-actions github-actions bot added the fix label Dec 5, 2025
@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.99%. Comparing base (219770e) to head (4e80f93).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1311   +/-   ##
=======================================
  Coverage   80.99%   80.99%           
=======================================
  Files          66       66           
  Lines        4499     4499           
  Branches      776      776           
=======================================
  Hits         3644     3644           
  Misses        840      840           
  Partials       15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@jescalada jescalada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix Andy!

@jescalada jescalada merged commit 4f73bf7 into finos:main Dec 6, 2025
14 checks passed
@andypols andypols deleted the fix-types-never-user-warning branch December 6, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants