From af4d6f3fb8c50d885fb03e109c2667230fc4d555 Mon Sep 17 00:00:00 2001 From: JamieSlome Date: Tue, 4 Jul 2023 16:25:55 +0100 Subject: [PATCH 1/3] fix: replace usage of Switch with Routes --- src/index.js | 6 +++--- src/ui/layouts/Admin.js | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/index.js b/src/index.js index 666fc66a9..052caf617 100644 --- a/src/index.js +++ b/src/index.js @@ -3,7 +3,7 @@ import React from 'react'; import ReactDOM from 'react-dom'; import {createBrowserHistory} from 'history'; -import {Router, Route, Switch, Redirect} from 'react-router-dom'; +import {Router, Route, Routes, Redirect} from 'react-router-dom'; // core components import Admin from './ui/layouts/Admin.js'; @@ -15,11 +15,11 @@ const hist = createBrowserHistory(); ReactDOM.render( - + - + , document.getElementById('root'), ); diff --git a/src/ui/layouts/Admin.js b/src/ui/layouts/Admin.js index c96baafa5..1814c5de4 100644 --- a/src/ui/layouts/Admin.js +++ b/src/ui/layouts/Admin.js @@ -1,7 +1,7 @@ /* eslint-disable max-len */ /* eslint-disable require-jsdoc */ import React from 'react'; -import {Switch, Route, Redirect} from 'react-router-dom'; +import {Routes, Route, Redirect} from 'react-router-dom'; import PerfectScrollbar from 'perfect-scrollbar'; import 'perfect-scrollbar/css/perfect-scrollbar.css'; import {makeStyles} from '@material-ui/core/styles'; @@ -16,7 +16,7 @@ import logo from '../assets/img/reactlogo.png'; let ps; const switchRoutes = ( - + {routes.map((prop, key) => { if (prop.layout === '/admin') { return ( @@ -30,7 +30,7 @@ const switchRoutes = ( return null; })} - + ); const useStyles = makeStyles(styles); From 84d515a23e213215d3544556e88eff41f623dd7f Mon Sep 17 00:00:00 2001 From: JamieSlome Date: Tue, 4 Jul 2023 17:42:12 +0100 Subject: [PATCH 2/3] fix: replace Redirect with Navigate, useHistory with useNavigate, & component with element on Route --- src/index.js | 8 ++++---- src/ui/layouts/Admin.js | 6 +++--- src/ui/views/Dashboard/Components/PushTable.js | 4 ++-- src/ui/views/Login/Login.js | 4 ++-- src/ui/views/OpenPushRequests/components/PushesTable.js | 8 ++++---- src/ui/views/PushDetails/PushDetails.js | 8 ++++---- src/ui/views/RepoDetails/Components/AddUser.js | 4 ++-- src/ui/views/RepoDetails/RepoDetails.js | 4 ++-- src/ui/views/RepoList/Components/Repositories.js | 8 ++++---- src/ui/views/User/User.js | 4 ++-- src/ui/views/UserList/Components/UserList.js | 8 ++++---- 11 files changed, 33 insertions(+), 33 deletions(-) diff --git a/src/index.js b/src/index.js index 052caf617..9e159b97c 100644 --- a/src/index.js +++ b/src/index.js @@ -3,7 +3,7 @@ import React from 'react'; import ReactDOM from 'react-dom'; import {createBrowserHistory} from 'history'; -import {Router, Route, Routes, Redirect} from 'react-router-dom'; +import {BrowserRouter as Router, Route, Routes, Navigate} from 'react-router-dom'; // core components import Admin from './ui/layouts/Admin.js'; @@ -16,9 +16,9 @@ const hist = createBrowserHistory(); ReactDOM.render( - - - + } /> + } /> + } /> , document.getElementById('root'), diff --git a/src/ui/layouts/Admin.js b/src/ui/layouts/Admin.js index 1814c5de4..37d4640c3 100644 --- a/src/ui/layouts/Admin.js +++ b/src/ui/layouts/Admin.js @@ -1,7 +1,7 @@ /* eslint-disable max-len */ /* eslint-disable require-jsdoc */ import React from 'react'; -import {Routes, Route, Redirect} from 'react-router-dom'; +import {Routes, Route, Navigate} from 'react-router-dom'; import PerfectScrollbar from 'perfect-scrollbar'; import 'perfect-scrollbar/css/perfect-scrollbar.css'; import {makeStyles} from '@material-ui/core/styles'; @@ -22,14 +22,14 @@ const switchRoutes = ( return ( ); } return null; })} - + ); diff --git a/src/ui/views/Dashboard/Components/PushTable.js b/src/ui/views/Dashboard/Components/PushTable.js index a661be367..7de67532f 100644 --- a/src/ui/views/Dashboard/Components/PushTable.js +++ b/src/ui/views/Dashboard/Components/PushTable.js @@ -6,7 +6,7 @@ import BugReport from '@material-ui/icons/BugReport'; import Code from '@material-ui/icons/Code'; import Table from '../../../components/Table/Table.js'; import CustomTabs from '../../../components/CustomTabs/CustomTabs.js'; -import {Redirect} from 'react-router-dom'; +import {Navigate} from 'react-router-dom'; export default function PushesWaitingAuthorizationGraph() { @@ -46,7 +46,7 @@ export default function PushesWaitingAuthorizationGraph() { if (isLoading) return (
Loading ...
); if (isError) return (
Something went wrong ...
); - if (!auth) return (); + if (!auth) return (); return ( + ); } diff --git a/src/ui/views/OpenPushRequests/components/PushesTable.js b/src/ui/views/OpenPushRequests/components/PushesTable.js index 256742efa..413093b71 100644 --- a/src/ui/views/OpenPushRequests/components/PushesTable.js +++ b/src/ui/views/OpenPushRequests/components/PushesTable.js @@ -3,7 +3,7 @@ import React, {useState, useEffect} from 'react'; import {makeStyles} from '@material-ui/core/styles'; import moment from 'moment'; -import {useHistory} from 'react-router-dom'; +import {useNavigate} from 'react-router-dom'; import Button from '@material-ui/core/Button'; import Table from '@material-ui/core/Table'; import TableBody from '@material-ui/core/TableBody'; @@ -12,7 +12,7 @@ import TableContainer from '@material-ui/core/TableContainer'; import TableHead from '@material-ui/core/TableHead'; import TableRow from '@material-ui/core/TableRow'; import Paper from '@material-ui/core/Paper'; -import {Redirect} from 'react-router-dom'; +import {Navigate} from 'react-router-dom'; import styles from '../../../assets/jss/material-dashboard-react/views/dashboardStyle.js'; import {getPushes} from '../../../services/git-push'; @@ -23,7 +23,7 @@ export default function PushesTable(props) { const [auth, setAuth] = useState(true); const [isLoading, setIsLoading] = useState(false); const [isError, setIsError] = useState(false); - const history = useHistory(); + const history = useNavigate(); const openPush = (push) => history.push(`/admin/push/${push}`); @@ -40,7 +40,7 @@ export default function PushesTable(props) { if (isLoading) return (
Loading ...
); if (isError) return (
Something went wrong ...
); - if (!auth) return (); + if (!auth) return (); return ( diff --git a/src/ui/views/PushDetails/PushDetails.js b/src/ui/views/PushDetails/PushDetails.js index 40911b2d5..ca275661d 100644 --- a/src/ui/views/PushDetails/PushDetails.js +++ b/src/ui/views/PushDetails/PushDetails.js @@ -1,9 +1,9 @@ /* eslint-disable max-len */ /* eslint-disable require-jsdoc */ import React, {useState, useEffect} from 'react'; -import {Redirect} from 'react-router-dom'; +import {Navigate} from 'react-router-dom'; import moment from 'moment'; -import {useHistory} from 'react-router-dom'; +import {useNavigate} from 'react-router-dom'; import Icon from '@material-ui/core/Icon'; import GridItem from '../../components/Grid/GridItem.js'; import GridContainer from '../../components/Grid/GridContainer.js'; @@ -28,7 +28,7 @@ export default function Dashboard(props) { const [auth, setAuth] = useState(true); const [isLoading, setIsLoading] = useState(true); const [isError, setIsError] = useState(false); - const history = useHistory(); + const history = useNavigate(); useEffect(() => { getPush(id, setIsLoading, setData, setAuth, setIsError); @@ -51,7 +51,7 @@ export default function Dashboard(props) { if (isLoading) return (
Loading ...
); if (isError) return (
Something went wrong ...
); - if (!auth) return (); + if (!auth) return (); let headerData = { title: 'Waiting Approval', diff --git a/src/ui/views/RepoDetails/Components/AddUser.js b/src/ui/views/RepoDetails/Components/AddUser.js index 3f568aa67..f594d1ab2 100644 --- a/src/ui/views/RepoDetails/Components/AddUser.js +++ b/src/ui/views/RepoDetails/Components/AddUser.js @@ -15,7 +15,7 @@ import Button from '../../../components/CustomButtons/Button.js'; import DialogTitle from '@material-ui/core/DialogTitle'; import Select from '@material-ui/core/Select'; import Dialog from '@material-ui/core/Dialog'; -import {Redirect} from 'react-router-dom'; +import {Navigate} from 'react-router-dom'; import {addUser} from '../../../services/repo.js'; import {getUsers} from '../../../services/user.js'; @@ -60,7 +60,7 @@ function AddUserDialog(props) { if (isLoading) return (
Loading ...
); if (isError) return (
Something went wrong ...
); - if (!auth) return (); + if (!auth) return (); console.log(JSON.stringify(props)); diff --git a/src/ui/views/RepoDetails/RepoDetails.js b/src/ui/views/RepoDetails/RepoDetails.js index e76a4517f..69b4782a5 100644 --- a/src/ui/views/RepoDetails/RepoDetails.js +++ b/src/ui/views/RepoDetails/RepoDetails.js @@ -1,7 +1,7 @@ /* eslint-disable max-len */ /* eslint-disable require-jsdoc */ import React, {useState, useEffect} from 'react'; -import {Redirect} from 'react-router-dom'; +import {Navigate} from 'react-router-dom'; // import Icon from '@material-ui/core/Icon'; import GridItem from '../../components/Grid/GridItem.js'; import GridContainer from '../../components/Grid/GridContainer.js'; @@ -53,7 +53,7 @@ export default function RepoDetails(props) { if (isLoading) return (
Loading ...
); if (isError) return (
Something went wrong ...
); - if (!auth) return (); + if (!auth) return (); return ( diff --git a/src/ui/views/RepoList/Components/Repositories.js b/src/ui/views/RepoList/Components/Repositories.js index 67645f134..2fce50d8a 100644 --- a/src/ui/views/RepoList/Components/Repositories.js +++ b/src/ui/views/RepoList/Components/Repositories.js @@ -2,7 +2,7 @@ /* eslint-disable require-jsdoc */ import React, {useState, useEffect} from 'react'; import {makeStyles} from '@material-ui/core/styles'; -import {useHistory} from 'react-router-dom'; +import {useNavigate} from 'react-router-dom'; import Button from '@material-ui/core/Button'; import Table from '@material-ui/core/Table'; import TableBody from '@material-ui/core/TableBody'; @@ -11,7 +11,7 @@ import TableContainer from '@material-ui/core/TableContainer'; import TableHead from '@material-ui/core/TableHead'; import TableRow from '@material-ui/core/TableRow'; import Paper from '@material-ui/core/Paper'; -import {Redirect} from 'react-router-dom'; +import {Navigate} from 'react-router-dom'; import styles from '../../../assets/jss/material-dashboard-react/views/dashboardStyle.js'; import {getRepos} from '../../../services/repo'; @@ -22,7 +22,7 @@ export default function Repositories(props) { const [auth, setAuth] = useState(true); const [isLoading, setIsLoading] = useState(false); const [isError, setIsError] = useState(false); - const history = useHistory(); + const history = useNavigate(); const openRepo = (repo) => history.push(`/admin/repo/${repo}`); @@ -39,7 +39,7 @@ export default function Repositories(props) { if (isLoading) return (
Loading ...
); if (isError) return (
Something went wrong ...
); - if (!auth) return (); + if (!auth) return (); return ( diff --git a/src/ui/views/User/User.js b/src/ui/views/User/User.js index 3cdcb881c..34e065db1 100644 --- a/src/ui/views/User/User.js +++ b/src/ui/views/User/User.js @@ -1,7 +1,7 @@ /* eslint-disable max-len */ /* eslint-disable require-jsdoc */ import React, {useState, useEffect} from 'react'; -import {Redirect} from 'react-router-dom'; +import {Navigate} from 'react-router-dom'; import Icon from '@material-ui/core/Icon'; import GridItem from '../../components/Grid/GridItem.js'; import GridContainer from '../../components/Grid/GridContainer.js'; @@ -49,7 +49,7 @@ export default function Dashboard(props) { if (isLoading) return (
Loading ...
); if (isError) return (
Something went wrong ...
); - if (!auth) return (); + if (!auth) return (); console.log(data); diff --git a/src/ui/views/UserList/Components/UserList.js b/src/ui/views/UserList/Components/UserList.js index f7d99581e..17b788a8f 100644 --- a/src/ui/views/UserList/Components/UserList.js +++ b/src/ui/views/UserList/Components/UserList.js @@ -2,7 +2,7 @@ /* eslint-disable require-jsdoc */ import React, {useState, useEffect} from 'react'; import {makeStyles} from '@material-ui/core/styles'; -import {useHistory} from 'react-router-dom'; +import {useNavigate} from 'react-router-dom'; import GridItem from '../../../components/Grid/GridItem.js'; import GridContainer from '../../../components/Grid/GridContainer.js'; import Button from '@material-ui/core/Button'; @@ -13,7 +13,7 @@ import TableContainer from '@material-ui/core/TableContainer'; import TableHead from '@material-ui/core/TableHead'; import TableRow from '@material-ui/core/TableRow'; import Paper from '@material-ui/core/Paper'; -import {Redirect} from 'react-router-dom'; +import {Navigate} from 'react-router-dom'; import styles from '../../../assets/jss/material-dashboard-react/views/dashboardStyle.js'; import {getUsers} from '../../../services/user'; import NewUser from './NewUser'; @@ -25,7 +25,7 @@ export default function UserList(props) { const [auth, setAuth] = useState(true); const [isLoading, setIsLoading] = useState(false); const [isError, setIsError] = useState(false); - const history = useHistory(); + const history = useNavigate(); const openUser = (username) => history.push(`/admin/user/${username}`); @@ -41,7 +41,7 @@ export default function UserList(props) { if (isLoading) return (
Loading ...
); if (isError) return (
Something went wrong ...
); - if (!auth) return (); + if (!auth) return (); return ( From 86692b21c10c4717937cf07ee43e085ad1fe6b39 Mon Sep 17 00:00:00 2001 From: Jamie Slome Date: Mon, 10 Jul 2023 20:25:29 +0100 Subject: [PATCH 3/3] chore: remove hasInstallScript from package-lock.json --- package-lock.json | 1 - 1 file changed, 1 deletion(-) diff --git a/package-lock.json b/package-lock.json index a9a65a790..1d0e44273 100644 --- a/package-lock.json +++ b/package-lock.json @@ -7,7 +7,6 @@ "": { "name": "@finos/git-proxy", "version": "1.0.0", - "hasInstallScript": true, "license": "Apache-2.0", "dependencies": { "@material-ui/core": "^4.11.0",