Skip to content

Conversation

@rgmz
Copy link
Contributor

@rgmz rgmz commented Feb 28, 2024

This PR makes two changes to the "Getting Started" section of the README:

  1. It should make the push command work with any default branch name.
    Currently, if blindly copied & pasted and the repository has a different default branch, people will receive the error 'error: src refspec {name} does not match any'.
  2. It explicitly states that SSH isn't supported yet.
    The instructions result in a confusing prompt + error if you only have SSH configured.
$ git push proxy main
Username for 'http://localhost:8000':
Password for 'http://localhost:8000':
remote: No anonymous write access.
fatal: Authentication failed for https://xxx

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 28, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@netlify
Copy link

netlify bot commented Feb 28, 2024

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit e07f908
🔍 Latest deploy log https://app.netlify.com/sites/endearing-brigadeiros-63f9d0/deploys/66031c0669f6c00007461c46

rgmz added 2 commits February 28, 2024 18:14
This makes the push command work with any default branch name. Currently, if blindly copied & pasted and the repository has a different default branch, people will receive the error 'error: src refspec {name} does not match any'.
@codecov
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.35%. Comparing base (caa1fb7) to head (e07f908).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #464   +/-   ##
=======================================
  Coverage   57.35%   57.35%           
=======================================
  Files          39       39           
  Lines        1060     1060           
=======================================
  Hits          608      608           
  Misses        452      452           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@maoo maoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maoo
Copy link
Member

maoo commented Feb 29, 2024

@JamieSlome @coopernetes - any issues merging this?

@rgmz - Given your interest in the project, I was wondering if you'd be also interested to join our bi-weekly Zoom meeting where we coordinate around project activities; if that's the case, please email help@finos.org and I'll send out all the info you need to join. Thank you!

@JamieSlome
Copy link
Member

@rgmz - any thoughts on the above comments? 👍 ❤️

Copy link
Member

@JamieSlome JamieSlome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🍰

@JamieSlome JamieSlome merged commit 56553b0 into finos:main Mar 26, 2024
@rgmz rgmz deleted the docs/getting-started branch March 26, 2024 19:08
Psingle20 pushed a commit to Psingle20/git-proxy that referenced this pull request Nov 27, 2024
Quality-of-life improvements to 'Getting Started' documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants