-
Notifications
You must be signed in to change notification settings - Fork 149
Quality-of-life improvements to 'Getting Started' documentation. #464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
This makes the push command work with any default branch name. Currently, if blindly copied & pasted and the repository has a different default branch, people will receive the error 'error: src refspec {name} does not match any'.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #464 +/- ##
=======================================
Coverage 57.35% 57.35%
=======================================
Files 39 39
Lines 1060 1060
=======================================
Hits 608 608
Misses 452 452 ☔ View full report in Codecov by Sentry. |
maoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@JamieSlome @coopernetes - any issues merging this? @rgmz - Given your interest in the project, I was wondering if you'd be also interested to join our bi-weekly Zoom meeting where we coordinate around project activities; if that's the case, please email help@finos.org and I'll send out all the info you need to join. Thank you! |
|
@rgmz - any thoughts on the above comments? 👍 ❤️ |
JamieSlome
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🍰
Quality-of-life improvements to 'Getting Started' documentation.
This PR makes two changes to the "Getting Started" section of the README:
Currently, if blindly copied & pasted and the repository has a different default branch, people will receive the error 'error: src refspec {name} does not match any'.
The instructions result in a confusing prompt + error if you only have SSH configured.