Skip to content

Conversation

@JamieSlome
Copy link
Member

Currently failing tests are not reported to the CI pipeline resulting in pull requests being merged even when tests are failing 👍

@JamieSlome JamieSlome added the bug Something isn't working label Mar 22, 2024
@JamieSlome JamieSlome self-assigned this Mar 22, 2024
@netlify
Copy link

netlify bot commented Mar 22, 2024

Deploy Preview for endearing-brigadeiros-63f9d0 ready!

Name Link
🔨 Latest commit 105b8c4
🔍 Latest deploy log https://app.netlify.com/sites/endearing-brigadeiros-63f9d0/deploys/65fd7b07faa1410008135518
😎 Deploy Preview https://deploy-preview-496--endearing-brigadeiros-63f9d0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@socket-security
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@types/express-serve-static-core@4.17.42 None +4 4.05 MB types
npm/@types/express@4.17.21 None +4 4.01 MB types
npm/@types/mime@1.3.5 None 0 3.78 kB types
npm/@types/serve-static@1.15.5 None +2 4 MB types
npm/@webassemblyjs/ast@1.11.6 None +5 341 kB xtuc
npm/@webassemblyjs/wasm-parser@1.11.6 None +7 329 kB xtuc
npm/accepts@1.3.8 None +3 268 kB dougwilson
npm/css-tree@1.1.3 None +1 1.55 MB lahmatiy
npm/has-bigints@1.0.2 None 0 12.8 kB ljharb
npm/mime-types@2.1.18 None +1 183 kB dougwilson
npm/obuf@1.1.2 None 0 19.1 kB indutny

🚮 Removed packages: npm/postcss-selector-parser@6.0.15, npm/postcss-value-parser@4.2.0, npm/prop-types@15.8.1, npm/react-dom@18.2.0, npm/react-fast-compare@3.2.2, npm/react-helmet-async@1.3.0, npm/react-is@16.13.1, npm/react-router@5.3.4, npm/react@18.2.0, npm/regexp.prototype.flags@1.5.2, npm/resolve@1.22.8, npm/safe-array-concat@1.1.2, npm/safe-buffer@5.2.1, npm/semver@7.5.4, npm/serialize-javascript@6.0.2, npm/set-function-name@2.0.2, npm/shell-quote@1.8.1, npm/signal-exit@3.0.7, npm/string-width@5.1.2, npm/svgo@2.8.0, npm/tapable@2.2.1, npm/terser-webpack-plugin@5.3.10, npm/terser@5.27.0, npm/tslib@2.6.2, npm/type-check@0.4.0, npm/type-fest@2.19.0, npm/unified@11.0.4, npm/unpipe@1.0.0, npm/util-deprecate@1.0.2, npm/vfile@6.0.1, npm/webpack-sources@3.2.3, npm/which-typed-array@1.1.15, npm/wrap-ansi@8.1.0, npm/yaml@1.10.2

View full report↗︎

@codecov
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.27%. Comparing base (c17ca39) to head (105b8c4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #496   +/-   ##
=======================================
  Coverage   57.27%   57.27%           
=======================================
  Files          39       39           
  Lines        1058     1058           
=======================================
  Hits          606      606           
  Misses        452      452           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JamieSlome JamieSlome merged commit f1be6bf into main Mar 22, 2024
@JamieSlome JamieSlome deleted the fix/report-on-coverage-only branch March 22, 2024 12:37
Psingle20 pushed a commit to Psingle20/git-proxy that referenced this pull request Nov 27, 2024
Report on coverage only and block CI on tests failure finos#495
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants