Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(fix): Remove NPM step condition #554

Merged
merged 3 commits into from
May 10, 2024
Merged

ci(fix): Remove NPM step condition #554

merged 3 commits into from
May 10, 2024

Conversation

eddie-knight
Copy link
Contributor

@eddie-knight eddie-knight commented May 10, 2024

This condition wasn't behaving as expected, removing.

Relates to #532

Copy link

netlify bot commented May 10, 2024

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit d143349
🔍 Latest deploy log https://app.netlify.com/sites/endearing-brigadeiros-63f9d0/deploys/663e317711da6f00085a2788

@github-actions github-actions bot added the fix label May 10, 2024
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.96%. Comparing base (44cc70d) to head (d143349).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #554   +/-   ##
=======================================
  Coverage   56.96%   56.96%           
=======================================
  Files          46       46           
  Lines        1566     1566           
=======================================
  Hits          892      892           
  Misses        674      674           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eddie-knight eddie-knight changed the title fix: Remove NPM step condition ci(fix): Remove NPM step condition May 10, 2024
Copy link
Member

@JamieSlome JamieSlome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🍰

@JamieSlome JamieSlome merged commit f92fd06 into finos:main May 10, 2024
13 checks passed
@eddie-knight eddie-knight deleted the patch-1 branch May 11, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants