Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support property search in query builder #1212

Merged
merged 3 commits into from
Jul 7, 2022

Conversation

gayathrir11
Copy link
Contributor

@gayathrir11 gayathrir11 commented Jun 13, 2022

Summary

Closes #782

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)
prop.mp4

@changeset-bot
Copy link

changeset-bot bot commented Jun 13, 2022

🦋 Changeset detected

Latest commit: 436dfbb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@finos/legend-query Minor
@finos/legend-extension-dsl-data-space Patch
@finos/legend-query-app Patch
@finos/legend-studio-extension-query-builder Patch
@finos/legend-graph-extension-collection Patch
@finos/legend-studio-app Patch
@finos/legend-taxonomy Patch
@finos/legend-query-deployment Patch
@finos/legend-manual-tests Patch
@finos/legend-taxonomy-app Patch
@finos/legend-studio-deployment Patch
@finos/legend-taxonomy-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@finos-cla-bot finos-cla-bot bot added the cla-present CLA Signed label Jun 14, 2022
@gayathrir11 gayathrir11 force-pushed the property_search branch 4 times, most recently from d744408 to ee0e88d Compare June 14, 2022 14:41
@gayathrir11 gayathrir11 marked this pull request as ready for review June 14, 2022 14:52
Copy link
Member

@MauricioUyaguari MauricioUyaguari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will keep reviewing tomorrow but left some comments.
2 additional thoughts based on the video.
The only word is not clear that it is clickable. Maybe underline the word when hovering over it. Want to let users know that it is clickable.
Also the results could use a bit of padding on the top. Seems too close to the search input.

Copy link
Member

@MauricioUyaguari MauricioUyaguari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we add integration tests for this change. Your example in the video might make a good example for testing.

@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #1212 (436dfbb) into master (cce3d6d) will increase coverage by 0.04%.
The diff coverage is 50.62%.

@@            Coverage Diff             @@
##           master    #1212      +/-   ##
==========================================
+ Coverage   41.70%   41.75%   +0.04%     
==========================================
  Files        1141     1143       +2     
  Lines       51556    51882     +326     
  Branches    11641    11783     +142     
==========================================
+ Hits        21503    21662     +159     
- Misses      29993    30153     +160     
- Partials       60       67       +7     
Impacted Files Coverage Δ
...src/components/QueryBuilderPropertySearchPanel.tsx 47.85% <47.85%> (ø)
...gend-query/src/stores/QueryBuilderExplorerState.ts 71.83% <50.00%> (+2.42%) ⬆️
...src/stores/QueryBuilderPropertySearchPanelState.ts 53.02% <53.02%> (ø)
packages/legend-query/src/QueryBuilder_Const.ts 100.00% <100.00%> (ø)
...query/src/components/QueryBuilderExplorerPanel.tsx 65.87% <100.00%> (ø)
.../legend-studio/src/components/editor/StatusBar.tsx 59.80% <0.00%> (-4.91%) ⬇️
...uery/src/components/QueryBuilderParameterPanel.tsx 42.05% <0.00%> (-3.87%) ⬇️
...egend-studio/src/components/editor/ActivityBar.tsx 60.00% <0.00%> (-1.00%) ⬇️

@gayathrir11 gayathrir11 force-pushed the property_search branch 4 times, most recently from 411348c to 25f70f8 Compare July 5, 2022 15:27
@gayathrir11 gayathrir11 force-pushed the property_search branch 2 times, most recently from d619370 to f1da92b Compare July 7, 2022 06:45
@MauricioUyaguari MauricioUyaguari merged commit ac58c74 into finos:master Jul 7, 2022
akphi added a commit to akphi/legend-studio that referenced this pull request Jul 7, 2022
akphi added a commit to akphi/legend-studio that referenced this pull request Jul 8, 2022
akphi added a commit to akphi/legend-studio that referenced this pull request Jul 9, 2022
akphi added a commit that referenced this pull request Jul 10, 2022
…1266)

* give more usage analytics

* fix problem with input with context doc do not properly receive focus

* bump dependencies

* minor fixes

* query builder: minor style fix for duplicated properties for projections

* introduce extension mechanism for AbstractPureGraphManager

* cleanup post #1212

* send analytics for more editors

* minor fixes to cleanup test warnings

* minor fix

* bump dependencies

* update typedoc setup

* remove project coordinate from dataspace tagged value for query

* bump dependencies

* minor cleanups

* reorganize Legend Query code

* update typedoc version

* publish doc website
jinanisha pushed a commit to jinanisha/legend-studio that referenced this pull request Aug 5, 2022
* Add algo for property search

* add support for property search

* add comments
jinanisha pushed a commit to jinanisha/legend-studio that referenced this pull request Aug 5, 2022
…inos#1266)

* give more usage analytics

* fix problem with input with context doc do not properly receive focus

* bump dependencies

* minor fixes

* query builder: minor style fix for duplicated properties for projections

* introduce extension mechanism for AbstractPureGraphManager

* cleanup post finos#1212

* send analytics for more editors

* minor fixes to cleanup test warnings

* minor fix

* bump dependencies

* update typedoc setup

* remove project coordinate from dataspace tagged value for query

* bump dependencies

* minor cleanups

* reorganize Legend Query code

* update typedoc version

* publish doc website
@gayathrir11 gayathrir11 deleted the property_search branch August 30, 2022 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-present CLA Signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Query Builder Property Search
3 participants