-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support property search in query builder #1212
Conversation
🦋 Changeset detectedLatest commit: 436dfbb The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
a377b8c
to
09ca365
Compare
d744408
to
ee0e88d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will keep reviewing tomorrow but left some comments.
2 additional thoughts based on the video.
The only
word is not clear that it is clickable. Maybe underline the word when hovering over it. Want to let users know that it is clickable.
Also the results could use a bit of padding on the top. Seems too close to the search input.
packages/legend-query/src/stores/QueryBuilderPropertySearchPanelState.ts
Outdated
Show resolved
Hide resolved
packages/legend-query/src/stores/QueryBuilderPropertySearchPanelState.ts
Show resolved
Hide resolved
ee0e88d
to
612bc0a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we add integration tests for this change. Your example in the video might make a good example for testing.
packages/legend-query/src/components/QueryBuilderProjectionPanel.tsx
Outdated
Show resolved
Hide resolved
packages/legend-query/src/components/QueryBuilderPropertySearchPanel.tsx
Outdated
Show resolved
Hide resolved
packages/legend-query/src/components/QueryBuilderPropertySearchPanel.tsx
Outdated
Show resolved
Hide resolved
packages/legend-query/src/components/QueryBuilderPropertySearchPanel.tsx
Outdated
Show resolved
Hide resolved
packages/legend-query/src/components/QueryBuilderPropertySearchPanel.tsx
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #1212 +/- ##
==========================================
+ Coverage 41.70% 41.75% +0.04%
==========================================
Files 1141 1143 +2
Lines 51556 51882 +326
Branches 11641 11783 +142
==========================================
+ Hits 21503 21662 +159
- Misses 29993 30153 +160
- Partials 60 67 +7
|
411348c
to
25f70f8
Compare
packages/legend-query/src/components/__tests__/QueryBuilder_PropertySearch.test.tsx
Outdated
Show resolved
Hide resolved
packages/legend-query/src/components/QueryBuilderExplorerPanel.tsx
Outdated
Show resolved
Hide resolved
packages/legend-query/src/components/QueryBuilderExplorerPanel.tsx
Outdated
Show resolved
Hide resolved
packages/legend-query/src/components/QueryBuilderExplorerPanel.tsx
Outdated
Show resolved
Hide resolved
packages/legend-query/src/components/QueryBuilderExplorerPanel.tsx
Outdated
Show resolved
Hide resolved
packages/legend-query/src/components/QueryBuilderFilterPanel.tsx
Outdated
Show resolved
Hide resolved
packages/legend-query/src/components/QueryBuilderPropertySearchPanel.tsx
Outdated
Show resolved
Hide resolved
packages/legend-query/src/components/QueryBuilderPropertySearchPanel.tsx
Outdated
Show resolved
Hide resolved
packages/legend-query/src/components/QueryBuilderPropertySearchPanel.tsx
Outdated
Show resolved
Hide resolved
packages/legend-query/src/components/QueryBuilderPropertySearchPanel.tsx
Show resolved
Hide resolved
d619370
to
f1da92b
Compare
f1da92b
to
72c1d25
Compare
packages/legend-query/src/components/QueryBuilderPropertySearchPanel.tsx
Show resolved
Hide resolved
packages/legend-query/src/stores/QueryBuilderPropertySearchPanelState.ts
Outdated
Show resolved
Hide resolved
packages/legend-query/src/components/QueryBuilderPropertySearchPanel.tsx
Outdated
Show resolved
Hide resolved
packages/legend-query/src/components/QueryBuilderPropertySearchPanel.tsx
Outdated
Show resolved
Hide resolved
packages/legend-query/src/stores/QueryBuilderPropertySearchPanelState.ts
Outdated
Show resolved
Hide resolved
packages/legend-query/src/components/QueryBuilderPropertySearchPanel.tsx
Outdated
Show resolved
Hide resolved
packages/legend-query/src/components/QueryBuilderPropertySearchPanel.tsx
Show resolved
Hide resolved
e30e680
to
5fefc44
Compare
…1266) * give more usage analytics * fix problem with input with context doc do not properly receive focus * bump dependencies * minor fixes * query builder: minor style fix for duplicated properties for projections * introduce extension mechanism for AbstractPureGraphManager * cleanup post #1212 * send analytics for more editors * minor fixes to cleanup test warnings * minor fix * bump dependencies * update typedoc setup * remove project coordinate from dataspace tagged value for query * bump dependencies * minor cleanups * reorganize Legend Query code * update typedoc version * publish doc website
* Add algo for property search * add support for property search * add comments
…inos#1266) * give more usage analytics * fix problem with input with context doc do not properly receive focus * bump dependencies * minor fixes * query builder: minor style fix for duplicated properties for projections * introduce extension mechanism for AbstractPureGraphManager * cleanup post finos#1212 * send analytics for more editors * minor fixes to cleanup test warnings * minor fix * bump dependencies * update typedoc setup * remove project coordinate from dataspace tagged value for query * bump dependencies * minor cleanups * reorganize Legend Query code * update typedoc version * publish doc website
Summary
Closes #782
How did you test this change?
prop.mp4