Support property search in query builder#1212
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 436dfbb The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
gayathrir11
force-pushed
the
property_search
branch
from
June 14, 2022 09:39
a377b8c to
09ca365
Compare
gayathrir11
force-pushed
the
property_search
branch
4 times, most recently
from
June 14, 2022 14:41
d744408 to
ee0e88d
Compare
gayathrir11
marked this pull request as ready for review
June 14, 2022 14:52
gayathrir11
requested review from
MauricioUyaguari,
akphi and
pierredebelen
as code owners
June 14, 2022 14:52
MauricioUyaguari
requested changes
Jun 22, 2022
MauricioUyaguari
left a comment
MauricioUyaguari
left a comment
Member
There was a problem hiding this comment.
Will keep reviewing tomorrow but left some comments.
2 additional thoughts based on the video.
The only word is not clear that it is clickable. Maybe underline the word when hovering over it. Want to let users know that it is clickable.
Also the results could use a bit of padding on the top. Seems too close to the search input.
gayathrir11
force-pushed
the
property_search
branch
from
June 23, 2022 13:47
ee0e88d to
612bc0a
Compare
MauricioUyaguari
requested changes
Jun 24, 2022
MauricioUyaguari
left a comment
MauricioUyaguari
left a comment
Member
There was a problem hiding this comment.
could we add integration tests for this change. Your example in the video might make a good example for testing.
Codecov Report
@@ Coverage Diff @@
## master #1212 +/- ##
==========================================
+ Coverage 41.70% 41.75% +0.04%
==========================================
Files 1141 1143 +2
Lines 51556 51882 +326
Branches 11641 11783 +142
==========================================
+ Hits 21503 21662 +159
- Misses 29993 30153 +160
- Partials 60 67 +7
|
gayathrir11
force-pushed
the
property_search
branch
4 times, most recently
from
July 5, 2022 15:27
411348c to
25f70f8
Compare
akphi
suggested changes
Jul 5, 2022
gayathrir11
force-pushed
the
property_search
branch
2 times, most recently
from
July 7, 2022 06:45
d619370 to
f1da92b
Compare
gayathrir11
force-pushed
the
property_search
branch
from
July 7, 2022 07:28
f1da92b to
72c1d25
Compare
akphi
reviewed
Jul 7, 2022
akphi
reviewed
Jul 7, 2022
akphi
reviewed
Jul 7, 2022
akphi
suggested changes
Jul 7, 2022
akphi
reviewed
Jul 7, 2022
gayathrir11
force-pushed
the
property_search
branch
from
July 7, 2022 15:10
e30e680 to
5fefc44
Compare
akphi
approved these changes
Jul 7, 2022
MauricioUyaguari
approved these changes
Jul 7, 2022
akphi
added a commit
to akphi/legend-studio
that referenced
this pull request
Jul 7, 2022
25 tasks
akphi
added a commit
to akphi/legend-studio
that referenced
this pull request
Jul 8, 2022
akphi
added a commit
to akphi/legend-studio
that referenced
this pull request
Jul 9, 2022
akphi
added a commit
that referenced
this pull request
Jul 10, 2022
…1266) * give more usage analytics * fix problem with input with context doc do not properly receive focus * bump dependencies * minor fixes * query builder: minor style fix for duplicated properties for projections * introduce extension mechanism for AbstractPureGraphManager * cleanup post #1212 * send analytics for more editors * minor fixes to cleanup test warnings * minor fix * bump dependencies * update typedoc setup * remove project coordinate from dataspace tagged value for query * bump dependencies * minor cleanups * reorganize Legend Query code * update typedoc version * publish doc website
jinanisha
pushed a commit
to jinanisha/legend-studio
that referenced
this pull request
Aug 5, 2022
* Add algo for property search * add support for property search * add comments
jinanisha
pushed a commit
to jinanisha/legend-studio
that referenced
this pull request
Aug 5, 2022
…inos#1266) * give more usage analytics * fix problem with input with context doc do not properly receive focus * bump dependencies * minor fixes * query builder: minor style fix for duplicated properties for projections * introduce extension mechanism for AbstractPureGraphManager * cleanup post finos#1212 * send analytics for more editors * minor fixes to cleanup test warnings * minor fix * bump dependencies * update typedoc setup * remove project coordinate from dataspace tagged value for query * bump dependencies * minor cleanups * reorganize Legend Query code * update typedoc version * publish doc website
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #782
How did you test this change?
prop.mp4