Skip to content

Show execution time and result set size #1244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Conversation

irisyngao
Copy link
Contributor

@irisyngao irisyngao commented Jun 28, 2022

Summary

Fixes #939

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)
demo.mov

@changeset-bot
Copy link

changeset-bot bot commented Jun 28, 2022

🦋 Changeset detected

Latest commit: 08bfee5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@finos/legend-query Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-query-app Patch
@finos/legend-studio-extension-query-builder Patch
@finos/legend-graph-extension-collection Patch
@finos/legend-studio-app Patch
@finos/legend-taxonomy Patch
@finos/legend-query-deployment Patch
@finos/legend-manual-tests Patch
@finos/legend-taxonomy-app Patch
@finos/legend-studio-deployment Patch
@finos/legend-taxonomy-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@finos-cla-bot finos-cla-bot bot added the cla-present CLA Signed label Jun 28, 2022
@irisyngao irisyngao marked this pull request as draft June 28, 2022 17:34
@irisyngao irisyngao marked this pull request as ready for review June 28, 2022 17:51
@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #1244 (08bfee5) into master (4dacea1) will increase coverage by 0.00%.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##           master    #1244   +/-   ##
=======================================
  Coverage   42.17%   42.17%           
=======================================
  Files        1126     1126           
  Lines       50389    50397    +8     
  Branches    11517    11520    +3     
=======================================
+ Hits        21250    21254    +4     
- Misses      29079    29083    +4     
  Partials       60       60           
Impacted Files Coverage Δ
...legend-query/src/stores/QueryBuilderResultState.ts 20.00% <25.00%> (+0.24%) ⬆️
...d-query/src/components/QueryBuilderResultPanel.tsx 54.54% <75.00%> (+1.31%) ⬆️

akphi
akphi previously approved these changes Jun 28, 2022
Copy link
Contributor

@akphi akphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to rebase as well

@irisyngao irisyngao force-pushed the resultPanel branch 2 times, most recently from f3a6303 to 2433c58 Compare June 28, 2022 18:49
@akphi akphi merged commit f104edb into finos:master Jun 28, 2022
@akphi akphi deleted the resultPanel branch June 28, 2022 19:18
jinanisha pushed a commit to jinanisha/legend-studio that referenced this pull request Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-present CLA Signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Show execution time and result set size
2 participants