Skip to content

allow DnD from projection to filter - #1350

Merged
MauricioUyaguari merged 1 commit into
finos:masterfrom
irisyngao:dndToFilter
Aug 2, 2022
Merged

allow DnD from projection to filter#1350
MauricioUyaguari merged 1 commit into
finos:masterfrom
irisyngao:dndToFilter

Conversation

@irisyngao

@irisyngao irisyngao commented Jul 28, 2022

Copy link
Copy Markdown
Contributor

Summary

Fixes #1349

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)
Screen.Recording.2022-07-29.at.8.57.22.AM.mov

@changeset-bot

changeset-bot Bot commented Jul 28, 2022

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: fd8fbfc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@finos/legend-application-query Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-extension-application-studio-query-builder Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-application-taxonomy-bootstrap Patch
@finos/legend-application-taxonomy Patch
@finos/legend-manual-tests Patch
@finos/legend-application-studio-deployment Patch
@finos/legend-application-taxonomy-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@finos-cla-bot finos-cla-bot Bot added the cla-present CLA Signed label Jul 28, 2022
@codecov

codecov Bot commented Jul 28, 2022

Copy link
Copy Markdown

Codecov Report

Merging #1350 (fd8fbfc) into master (428ef39) will increase coverage by 0.00%.
The diff coverage is 33.33%.

@@           Coverage Diff           @@
##           master    #1350   +/-   ##
=======================================
  Coverage   41.73%   41.73%           
=======================================
  Files        1187     1187           
  Lines       52595    52602    +7     
  Branches    11954    11957    +3     
=======================================
+ Hits        21952    21955    +3     
- Misses      30573    30576    +3     
- Partials       70       71    +1     
Impacted Files Coverage Δ
...n-query/src/components/QueryBuilderFilterPanel.tsx 56.42% <25.00%> (-0.66%) ⬇️
...cation-query/src/stores/QueryBuilderFilterState.ts 49.37% <100.00%> (+0.15%) ⬆️

Comment thread .changeset/cyan-otters-exercise.md Outdated
Comment thread packages/legend-application-query/src/components/QueryBuilderFilterPanel.tsx Outdated
@MauricioUyaguari
MauricioUyaguari merged commit 4e50f73 into finos:master Aug 2, 2022
@irisyngao
irisyngao deleted the dndToFilter branch August 25, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-present CLA Signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: Allow DnD from Projection to Filter panel

3 participants