support query execution cancellation #1358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YannanGao-gs
requested review from
pierredebelen,
akphi and
MauricioUyaguari
as code owners
🦋 Changeset detectedLatest commit: fa1e8e8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## master #1358 +/- ##
=======================================
Coverage 41.89% 41.90%
=======================================
Files 1176 1176
Lines 52433 52457 +24
Branches 11918 11930 +12
=======================================
+ Hits 21969 21980 +11
- Misses 30393 30405 +12
- Partials 71 72 +1
|
YannanGao-gs
force-pushed
the
cancelExecution
branch
from
ca2b489
to
337008d
Compare
akphi
reviewed
Aug 2, 2022
packages/legend-application-query/src/stores/QueryBuilderResultState.ts
Outdated
Show resolved
Hide resolved
akphi
requested changes
Aug 2, 2022
packages/legend-application-query/src/components/QueryBuilderResultPanel.tsx
Outdated
Show resolved
Hide resolved
packages/legend-application-query/src/components/QueryBuilderResultPanel.tsx
Outdated
Show resolved
Hide resolved
packages/legend-application-query/src/components/QueryBuilderResultPanel.tsx
Outdated
Show resolved
Hide resolved
YannanGao-gs
force-pushed
the
cancelExecution
branch
2 times, most recently
from
51841eb
to
5e3e3df
Compare
akphi
requested changes
Aug 2, 2022
| @@ -336,6 +336,41 @@ | |||
| @include flexVCenter; | |||
| } | |||
|
|
|||
| &__stop-btn { | |||
There was a problem hiding this comment.
let's just use btn--dark btn--caution
packages/legend-application-query/src/components/QueryBuilderResultPanel.tsx
Outdated
Show resolved
Hide resolved
akphi
requested changes
Aug 3, 2022
packages/legend-application-query/src/stores/QueryBuilderResultState.ts
Outdated
Show resolved
Hide resolved
YannanGao-gs
force-pushed
the
cancelExecution
branch
from
d2800ca
to
47adda9
Compare
akphi
requested changes
Aug 3, 2022
packages/legend-application-query/src/components/QueryBuilderResultPanel.tsx
Outdated
Show resolved
Hide resolved
akphi
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1357
How did you test this change?
Screen.Recording.2022-08-03.at.11.48.01.AM.mov