Block certain actions when query is not valid #1359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gayathrir11
requested review from
pierredebelen,
akphi and
MauricioUyaguari
as code owners
🦋 Changeset detectedLatest commit: fa13374 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## master #1359 +/- ##
=======================================
Coverage 41.88% 41.89%
=======================================
Files 1176 1176
Lines 52500 52509 +9
Branches 11943 11945 +2
=======================================
+ Hits 21989 21998 +9
Misses 30439 30439
Partials 72 72
|
|
@gayathrir11 It seems to me that users can't set the filter value to an empty string even if they want to? (based on your pr) |
packages/legend-application-query/src/components/QueryBuilderFilterPanel.tsx
Outdated
Show resolved
Hide resolved
MauricioUyaguari
requested changes
Aug 1, 2022
packages/legend-application-query/src/stores/QueryBuilderProjectionState.ts
Outdated
Show resolved
Hide resolved
gayathrir11
force-pushed
the
block
branch
4 times, most recently
from
31b5f5b to
ac5ecbd
Compare
irisyngao
reviewed
Aug 3, 2022
packages/legend-application-query/src/stores/QueryBuilderProjectionState.ts
Show resolved
Hide resolved
packages/legend-application-query/src/stores/QueryBuilderFilterState.ts
Outdated
Show resolved
Hide resolved
MauricioUyaguari
requested changes
Aug 3, 2022
MauricioUyaguari
approved these changes
Aug 5, 2022
2 tasks
2 tasks
xannem
pushed a commit
to xannem/legend-studio
that referenced
this pull request
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #1345
How did you test this change?
New.video.mp4