More unit test coverage. #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…feature/unittesting * 'feature/unittesting' of github.com:dpnova/cyclone: Allow setting an app_builder attribute on a TestCase.
…feature/unittesting * 'feature/unittesting' of github.com:dpnova/cyclone: Ensure the right param data is available on POST and friends. Enable cookie interactions (and sessions) in the test client. Include new testing and tests packages in the setup.py We dont care about coverage on setup.py Fix fiorix#138: validate HTTP headers.
* clear_all_cookies * redirect * write Merge branch 'master' into feature/unittesting * master: Fixed incorrectly formatted Expires header Changing setup.py dependancies to pyopenssl to make it optional Deleted blank line. Changed body for postdata in facebook_request in FacebookGraphMixin. Test file created. Pass variable arg in url to bind function in SSE Pass variable arg in url to bind function in SSE Added note about numeric channel names in redis Added passage in Added kwarg support to url reverse procedure. added logout to dropbox example dropbox auth demo Fix small doco bug in mail.Message. Fix docstrings of web.RequestHandler.write_error Copy/Paste error Forgot to commit template.py It is now possible to use in templates. Added autoescape tests, fixed lack of single quote escaping. Added statement. Conflicts: cyclone/tests/test_web.py
|
The cookies/days test failed. |
|
Thanks mate I'll look into it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed other people are starting to add their own unit tests which may potentially clash with tests I've been adding. So I'm going to open PR's more regularly to ensure that people are working with the latest version of the tests.
Cheers!