Large multi-bulk data results in maximum recursion depth exceeded #10

Closed
jimrollenhagen opened this Issue Jan 28, 2011 · 9 comments

Projects

None yet

5 participants

@jimrollenhagen

Reading large multi-bulk data results in maximum recursion depth exceeded.

This was a known issue in txRedis and has been fixed since last June (deldotdr/txRedis@37b0528). Would appreciate if you could implement the fix. I also may look into implementing and sending a pull request when I have some free time (which could be a while).

@boracengiz

I have the same issue , how can it be fixed? Your help is appreciated. Thanks.

@jimrollenhagen

@boracengiz I actually didn't need such a large amount of data for my application, so I just left it as is. Found this bug when trying to really push the limits of my application.

@jimrollenhagen

Also, it looks like there's a ton of changes to the protocol. I didn't look deep enough to tell, but this may have since been fixed...

@jeethu
Contributor
jeethu commented Mar 8, 2012

@jimrollenhagen I just tried the testcase that you mentioned from txRedis and it was still there. I've got a fix and a test for this on my fork. I'll send a pull request if @fiorix is ok with it.

@fiorix
Owner
fiorix commented Mar 9, 2012

Yes!

@jimrollenhagen

Sweet! Now to look for an excuse to use this library again... Also thank you fiorix for the great library :)

@fiorix
Owner
fiorix commented Mar 9, 2012

thanks!

@jeethu
Contributor
jeethu commented Mar 12, 2012

Now that @gleicon has merged my pull request to fix this issue, could we close this issue ?

@gleicon
Collaborator
gleicon commented Mar 12, 2012

sure, my bad. thanks.

@gleicon gleicon closed this Mar 12, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment