Skip to content

Conversation

@MoritzWeber0
Copy link
Member

No description provided.

@github-actions
Copy link

Hi there! 👋

Thank you for your contribution to the FIP Guide! 🚀
We appreciate your effort in making rail staff travel information more accessible. 🚄

Checklist before merging:

  • Added a description to the Pull Request
  • Checked the License of new pictures (non-commercial use without attribution)
  • Modified content in English
  • Modified content in German
  • Modified content in French

@netlify
Copy link

netlify bot commented Oct 14, 2025

Deploy Preview for fipguide ready!

Name Link
🔨 Latest commit 2042345
🔍 Latest deploy log https://app.netlify.com/projects/fipguide/deploys/68f4ac12bb260d00089f3a04
😎 Deploy Preview https://deploy-preview-396--fipguide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@MoritzWeber0
Copy link
Member Author

MoritzWeber0 commented Oct 14, 2025

@therobrob Do you have any idea why the indicator is cut-off in the light mode version, but not in the dark mode version?

There is a small white gap between the screen border and the indicator:
image

therobrob
therobrob previously approved these changes Oct 14, 2025
@therobrob
Copy link
Member

Seems to work (although I doesn’t understand the mixin 100%)

@therobrob
Copy link
Member

i think the small gap is present in light and dark mode. We have the border around the content-element, which is transparent in light mode. I've made it visible with this lightgreen color :)

Bildschirmfoto 2025-10-18 um 12 13 41 Bildschirmfoto 2025-10-18 um 12 13 28

@MoritzWeber0 MoritzWeber0 marked this pull request as ready for review October 18, 2025 19:12
@MoritzWeber0
Copy link
Member Author

i think the small gap is present in light and dark mode. We have the border around the content-element, which is transparent in light mode. I've made it visible with this lightgreen color :)

Thanks! I removed the borders on the left & right on mobile to avoid the issue.
Also removed the mixin, it was too complex for what it was doing and replaced it with two simple CSS rules.

@therobrob therobrob merged commit aef3854 into main Oct 19, 2025
7 checks passed
@therobrob therobrob deleted the fix/toc-indicator-mobile branch October 19, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants