Skip to content

Conversation

@MoritzWeber0
Copy link
Member

@MoritzWeber0 MoritzWeber0 commented Oct 18, 2025

Especially on mobile devices, space is limited and users may not have enough space to close the search if they want to. This PR changes the "open search" behavior to a "toggle search" behavior (open if search is closed, close if search is open).

In addition, two bugs are fixed:

  • The overlay wasn't displayed when the user navigated to the search field on the home page via tab.
  • The overlay wasn't closed if the search was opened via click and then moved out using the tab character (this will probably change when we implement the focus trapping, but for now it's the best solution I think).

@netlify
Copy link

netlify bot commented Oct 18, 2025

Deploy Preview for fipguide ready!

Name Link
🔨 Latest commit 251cc30
🔍 Latest deploy log https://app.netlify.com/projects/fipguide/deploys/68fa43479ce3b70008a823ae
😎 Deploy Preview https://deploy-preview-424--fipguide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

Hi there! 👋

Thank you for your contribution to the FIP Guide! 🚀
We appreciate your effort in making rail staff travel information more accessible. 🚄

Checklist before merging:

  • Added a description to the Pull Request
  • Checked the License of new pictures (non-commercial use without attribution)
  • Modified content in English
  • Modified content in German
  • Modified content in French

@MoritzWeber0 MoritzWeber0 force-pushed the fix/close-search-on-button-click branch from d242002 to 289635c Compare October 18, 2025 15:21
@MoritzWeber0 MoritzWeber0 marked this pull request as draft October 20, 2025 21:23
@MoritzWeber0 MoritzWeber0 marked this pull request as ready for review October 21, 2025 09:22
@MoritzWeber0 MoritzWeber0 force-pushed the fix/close-search-on-button-click branch from b0075a2 to ccf6116 Compare October 21, 2025 20:24
Copy link
Member

@therobrob therobrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nice! Thank you!

@therobrob therobrob merged commit 8543bfb into main Oct 23, 2025
7 checks passed
@therobrob therobrob deleted the fix/close-search-on-button-click branch October 23, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants