Add and enforce checkstyle, lint, findbugs, and pmd (#420)

firebase · Dec 6, 2016 · ac1fb39 · ac1fb39
1 parent 5bb61d1
commit ac1fb39
Show file tree

Hide file tree

Showing 93 changed files with 1,179 additions and 799 deletions.
diff --git a/.gitignore b/.gitignore
@@ -1,10 +1,7 @@
 .gradle
+/**/*.iml
 /local.properties
 .idea
 .DS_Store
 /build
-/captures
-/library/target
-/**/*.iml
 google-services.json
-build/
diff --git a/.travis.yml b/.travis.yml
@@ -11,12 +11,45 @@ cache:
     - $HOME/.gradle/wrapper/
 android:
   components:
-    - platform-tools
     - tools
     - build-tools-25.0.1
     - android-25
-
-    # Extras
-    - extra-google-m2repository
+    - platform-tools
     - extra-android-m2repository
-script: ./gradlew clean :library:testAll :library:prepareArtifacts
+    - extra-google-m2repository
+before_script: mv library/google-services.json app/google-services.json
+script: ./gradlew clean assembleDebug check
+after_failure:
+  # tests
+  - cat app/build/reports/tests/testDebugUnitTest/index.html
+  - cat auth/build/reports/tests/testDebugUnitTest/index.html
+  - cat database/build/reports/tests/testDebugUnitTest/index.html
+  - cat storage/build/reports/tests/testDebugUnitTest/index.html
+
+  # app
+  - cat app/build/reports/checkstyle.html
+  - cat app/build/reports/lint-results.xml
+  - cat app/build/reports/lint-results.html
+  - cat app/build/reports/findbugs.html
+  - cat app/build/reports/pmd.html
+
+  # auth
+  - cat auth/build/reports/checkstyle.html
+  - cat auth/build/reports/lint-results.xml
+  - cat auth/build/reports/lint-results.html
+  - cat auth/build/reports/findbugs.html
+  - cat auth/build/reports/pmd.html
+
+  # database
+  - cat database/build/reports/checkstyle.html
+  - cat database/build/reports/lint-results.xml
+  - cat database/build/reports/lint-results.html
+  - cat database/build/reports/findbugs.html
+  - cat database/build/reports/pmd.html
+
+  # storage
+  - cat storage/build/reports/checkstyle.html
+  - cat storage/build/reports/lint-results.xml
+  - cat storage/build/reports/lint-results.html
+  - cat storage/build/reports/findbugs.html
+  - cat storage/build/reports/pmd.html
diff --git a/app/build.gradle b/app/build.gradle
@@ -1,6 +1,7 @@
 apply plugin: 'com.android.application'
 apply plugin: 'com.neenbedankt.android-apt'
-apply from: "../common/constants.gradle"
+apply from: "../constants.gradle"
+apply from: '../library/quality/quality.gradle'
 
 android {
     compileSdkVersion compileSdk

diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml
@@ -9,9 +9,11 @@
     <application
         android:name=".auth.LeakCatcher"
         android:allowBackup="true"
+        android:fullBackupContent="true"
         android:icon="@mipmap/ic_launcher"
         android:label="@string/app_name"
-        android:theme="@style/AppTheme">
+        android:theme="@style/AppTheme"
+        android:supportsRtl="true">
         <activity android:name=".ChooserActivity">
             <intent-filter>
                 <action android:name="android.intent.action.MAIN"/>

diff --git a/app/src/main/java/com/firebase/uidemo/ChooserActivity.java b/app/src/main/java/com/firebase/uidemo/ChooserActivity.java
@@ -77,22 +77,21 @@ public void onItemClick(int position) {
     public static class MyArrayAdapter extends ArrayAdapter<Class> {
 
         private Context mContext;
-        private Class[] mClasses;
 
-        public MyArrayAdapter(Context context, int resource, Class[] objects) {
+        public MyArrayAdapter(Context context, int resource, Class... objects) {
             super(context, resource, objects);
-
             mContext = context;
-            mClasses = objects;
         }
 
         @Override
         public View getView(int position, View convertView, ViewGroup parent) {
-            View view = convertView;
+            View view;
 
             if (convertView == null) {
                 LayoutInflater inflater = (LayoutInflater) mContext.getSystemService(LAYOUT_INFLATER_SERVICE);
                 view = inflater.inflate(android.R.layout.simple_list_item_2, null);
+            } else {
+                view = convertView;
             }
 
             ((TextView) view.findViewById(android.R.id.text1)).setText(DESCRIPTION_NAMES[position]);

diff --git a/app/src/main/java/com/firebase/uidemo/auth/SignedInActivity.java b/app/src/main/java/com/firebase/uidemo/auth/SignedInActivity.java
@@ -28,9 +28,7 @@
 import android.view.View;
 import android.widget.ImageView;
 import android.widget.TextView;
-import butterknife.BindView;
-import butterknife.ButterKnife;
-import butterknife.OnClick;
+
 import com.bumptech.glide.Glide;
 import com.firebase.ui.auth.AuthUI;
 import com.firebase.ui.auth.IdpResponse;
@@ -42,8 +40,13 @@
 import com.google.firebase.auth.FirebaseAuth;
 import com.google.firebase.auth.FirebaseUser;
 import com.google.firebase.auth.GoogleAuthProvider;
+
 import java.util.Iterator;
 
+import butterknife.BindView;
+import butterknife.ButterKnife;
+import butterknife.OnClick;
+
 public class SignedInActivity extends AppCompatActivity {
     private static final String EXTRA_IDP_RESPONSE = "extra_idp_response";
 
@@ -144,7 +147,7 @@ private void populateProfile() {
         mUserDisplayName.setText(
                 TextUtils.isEmpty(user.getDisplayName()) ? "No display name" : user.getDisplayName());
 
-        StringBuilder providerList = new StringBuilder();
+        StringBuilder providerList = new StringBuilder(100);
 
         providerList.append("Providers used: ");
 

diff --git a/app/src/main/java/com/firebase/uidemo/database/ChatActivity.java b/app/src/main/java/com/firebase/uidemo/database/ChatActivity.java
@@ -47,11 +47,9 @@
 import com.google.firebase.database.Query;
 
 public class ChatActivity extends AppCompatActivity implements FirebaseAuth.AuthStateListener {
-
-    public static final String TAG = "RecyclerViewDemo";
+    private static final String TAG = "RecyclerViewDemo";
 
     private FirebaseAuth mAuth;
-    private DatabaseReference mRef;
     private DatabaseReference mChatRef;
     private Button mSendButton;
     private EditText mMessageEdit;
@@ -71,8 +69,7 @@ protected void onCreate(Bundle savedInstanceState) {
         mSendButton = (Button) findViewById(R.id.sendButton);
         mMessageEdit = (EditText) findViewById(R.id.messageEdit);
 
-        mRef = FirebaseDatabase.getInstance().getReference();
-        mChatRef = mRef.child("chats");
+        mChatRef = FirebaseDatabase.getInstance().getReference().child("chats");
 
         mSendButton.setOnClickListener(new View.OnClickListener() {
             @Override
@@ -146,7 +143,7 @@ private void attachRecyclerViewAdapter() {
             @Override
             public void populateViewHolder(ChatHolder chatView, Chat chat, int position) {
                 chatView.setName(chat.getName());
-                chatView.setText(chat.getText());
+                chatView.setText(chat.getMessage());
 
                 FirebaseUser currentUser = mAuth.getCurrentUser();
                 if (currentUser != null && chat.getUid().equals(currentUser.getUid())) {
@@ -188,7 +185,7 @@ public void onComplete(@NonNull Task<AuthResult> task) {
     }
 
     public boolean isSignedIn() {
-        return (mAuth.getCurrentUser() != null);
+        return mAuth.getCurrentUser() != null;
     }
 
     public void updateUI() {
@@ -198,30 +195,42 @@ public void updateUI() {
     }
 
     public static class Chat {
-
-        String name;
-        String text;
-        String uid;
+        private String mName;
+        private String mMessage;
+        private String mUid;
 
         public Chat() {
+            // Needed for Firebase
         }
 
-        public Chat(String name, String uid, String message) {
-            this.name = name;
-            this.text = message;
-            this.uid = uid;
+        public Chat(String name, String message, String uid) {
+            mName = name;
+            mMessage = message;
+            mUid = uid;
         }
 
         public String getName() {
-            return name;
+            return mName;
+        }
+
+        public void setName(String name) {
+            mName = name;
+        }
+
+        public String getMessage() {
+            return mMessage;
+        }
+
+        public void setMessage(String message) {
+            mMessage = message;
         }
 
         public String getUid() {
-            return uid;
+            return mUid;
         }
 
-        public String getText() {
-            return text;
+        public void setUid(String uid) {
+            mUid = uid;
         }
     }
 

diff --git a/app/src/main/res/drawable/chat_message_arrow.xml b/app/src/main/res/drawable/chat_message_arrow.xml
@@ -10,6 +10,6 @@
         <stroke
             android:color="@android:color/transparent"
             android:width="10dp"/>
-        <solid android:color="@color/material_grey_300"/>
+        <solid android:color="@color/material_gray_300"/>
     </shape>
 </rotate>
diff --git a/app/src/main/res/drawable/chat_message_background.xml b/app/src/main/res/drawable/chat_message_background.xml
@@ -3,5 +3,5 @@
     xmlns:android="http://schemas.android.com/apk/res/android"
     android:shape="rectangle">
     <corners android:radius="4dp"/>
-    <solid android:color="@color/material_grey_300"/>
+    <solid android:color="@color/material_gray_300"/>
 </shape>
diff --git a/app/src/main/res/layout/activity_chat.xml b/app/src/main/res/layout/activity_chat.xml
@@ -26,23 +26,24 @@
         android:layout_alignParentLeft="true"
         android:layout_alignParentStart="true"
         android:orientation="horizontal"
-        android:paddingStart="16dp"
         android:paddingEnd="16dp"
-        android:paddingLeft="16dp">
+        android:paddingLeft="16dp"
+        android:paddingStart="16dp">
 
         <EditText
             android:id="@+id/messageEdit"
             android:layout_width="0dp"
             android:layout_height="wrap_content"
-            android:layout_weight="1"/>
+            android:layout_weight="1"
+            android:inputType="text"/>
 
         <Button
             android:id="@+id/sendButton"
             style="@style/Widget.AppCompat.Button.Borderless.Colored"
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
             android:layout_gravity="bottom|end"
-            android:text="Send"/>
+            android:text="@string/send"/>
 
     </LinearLayout>
 

diff --git a/app/src/main/res/layout/activity_image.xml b/app/src/main/res/layout/activity_image.xml
@@ -15,20 +15,20 @@
         style="@style/TextAppearance.AppCompat.Medium"
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
-        android:text="Upload"/>
+        android:text="@string/upload"/>
 
     <Button
         android:id="@+id/button_choose_photo"
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
-        android:text="Choose Image"/>
+        android:text="@string/choose_image"/>
 
     <TextView
         style="@style/TextAppearance.AppCompat.Medium"
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
         android:layout_marginTop="20dp"
-        android:text="Download"/>
+        android:text="@string/download"/>
 
     <LinearLayout
         android:layout_width="wrap_content"
@@ -40,14 +40,15 @@
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
             android:enabled="false"
-            android:text="Download"/>
+            android:text="@string/download"/>
 
     </LinearLayout>
 
     <ImageView
         android:id="@+id/first_image"
         android:layout_width="match_parent"
         android:layout_height="match_parent"
+        android:contentDescription="@string/accessibility_downloaded_image"
         android:scaleType="centerCrop"
         android:src="#E6E6E6"
         android:visibility="invisible"

diff --git a/app/src/main/res/layout/auth_ui_layout.xml b/app/src/main/res/layout/auth_ui_layout.xml
@@ -13,8 +13,8 @@
         android:layout_marginLeft="24dp"
         android:layout_marginRight="24dp"
         android:layout_marginTop="16dp"
-        android:paddingBottom="32dp"
-        android:orientation="vertical">
+        android:orientation="vertical"
+        android:paddingBottom="32dp">
 
         <TextView
             style="@style/Base.TextAppearance.AppCompat.Headline"
@@ -167,8 +167,8 @@
         </RadioGroup>
 
         <TextView
-            style="@style/Base.TextAppearance.AppCompat.Subhead"
             android:id="@+id/facebook_scopes_label"
+            style="@style/Base.TextAppearance.AppCompat.Subhead"
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
             android:layout_marginBottom="8dp"
@@ -190,8 +190,8 @@
             android:text="@string/photos"/>
 
         <TextView
-            style="@style/Base.TextAppearance.AppCompat.Subhead"
             android:id="@+id/google_scopes_label"
+            style="@style/Base.TextAppearance.AppCompat.Subhead"
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
             android:layout_marginBottom="8dp"
@@ -210,7 +210,7 @@
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
             android:checked="false"
-            android:text="Drive File"/>
+            android:text="@string/drive_file"/>
 
         <TextView
             style="@style/Base.TextAppearance.AppCompat.Subhead"