Fix Issue #1608 - retry() failing in FirestorePagingAdapter #1609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samtstern
approved these changes
Mar 27, 2019
| private final Observer<FirestoreDataSource> mDataSourceObserver = new Observer<FirestoreDataSource>() { | ||
| @Override | ||
| public void onChanged(@Nullable FirestoreDataSource source) { | ||
|
|
There was a problem hiding this comment.
Can we add a comment inside here explaining why we need an empty observer so that future people who read this code know?
There was a problem hiding this comment.
@samtstern yes.
What comment should be added ?
Please suggest me.
There was a problem hiding this comment.
//Observer to hold the value for FirestoreDataSource ??
|
Suggest me comment to write. |
|
I'd say something like: "LiveData created via Transformation do not have a
value until an Observer is attached. We attach this empty observer so that
our getValue() calls return non-null later."
…On Wed, Mar 27, 2019, 7:05 PM Shreyas Patil ***@***.***> wrote:
Suggest me comment to write.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1609 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIEw6og5i0mDCu5RIMI57yFVzlvQmQJSks5vbCOFgaJpZM4cOj8r>
.
|
|
Fine! |
|
@samtstern We should add this in |
|
@PatilShreyas yep that's fine with me. I'll wait to merge until those changes are made also |
Updated a comment for Observer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have fixed
retry()failing and added a new methodrefresh()to refresh the list from the beginning as issue #1608