Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to get occurred exception - Issue 1592 #1615

Merged

Conversation

@PatilShreyas
Copy link
Contributor

PatilShreyas commented Apr 1, 2019

As issue #1592,
I have updated code as FirebaseRecyclerPagingAdapter and added an ability to get the occurred Exception while using FirestorePagingAdapter.

To use this, the user can Override onError() method of Adapter class.

e.g.

 @Override
 protected void onError(@NonNull Exception e) {
          mSwipeRefreshLayout.setRefreshing(false);
          Log.e(TAG, e.getMessage(), e);
 }
Updated a comment for Observer.
@PatilShreyas PatilShreyas requested a review from samtstern as a code owner Apr 1, 2019
@samtstern

This comment has been minimized.

Copy link
Member

samtstern commented Apr 1, 2019

@PatilShreyas thank you again!

@samtstern samtstern added this to the 4.4.0 milestone Apr 1, 2019
@samtstern samtstern merged commit dba6df5 into firebase:version-4.4.0-dev Apr 1, 2019
2 checks passed
2 checks passed
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PatilShreyas

This comment has been minimized.

Copy link
Contributor Author

PatilShreyas commented Apr 1, 2019

Welcome!
Love Firebase !! 🔥🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.