Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method to update options at runtime [Paging Adapters] #1692

Merged

Conversation

@PatilShreyas
Copy link
Contributor

PatilShreyas commented Oct 9, 2019

I have added option to change options at runtime in FirestorePagingAdapter class.
All LiveData<> objects should be re-initialised after changing options. So, I have removed their final modifier and also added new init() method which initializes LiveData<> objects from constructor and from updateOptions method.

Closes: #1677

@PatilShreyas PatilShreyas requested a review from samtstern as a code owner Oct 9, 2019
@googlebot googlebot added the cla: yes label Oct 9, 2019
@samtstern

This comment has been minimized.

Copy link
Member

samtstern commented Oct 9, 2019

@PatilShreyas LGTM thank you!

@samtstern samtstern merged commit 2e9fe25 into firebase:version-6.0.3-dev Oct 9, 2019
2 checks passed
2 checks passed
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@samtstern samtstern added this to the 6.0.3 milestone Oct 9, 2019
@PatilShreyas

This comment has been minimized.

Copy link
Contributor Author

PatilShreyas commented Oct 10, 2019

@samtstern Anytime!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.