Skip to content

Conversation

@dakeshi
Copy link
Contributor

@dakeshi dakeshi commented Jul 4, 2016

I make PR to solve #75, #67 issues.

Add podspec for local dev

s.source = { :git => 'https://github.com/firebase/FirebaseUI-iOS.git', :tag => s.version }

s.subspec 'AuthBase' do |authbase|
authbase.source_files = 'Auth/AuthUI/Source/.{h,m}'
authbase.resource_bundles = {'FirebaseAuthUIBundle' => ['Auth/AuthUI/Resources/
.png', 'Auth/AuthUI/Strings//.strings', 'Auth/AuthUI/Source/.xib']}

Create new example project

  • simple google auth UI.
  • The problem : If user try to sign in again, it still needs the authentication process.
  • How to test: Add GoogleService-Info.plist and URL scheme about REVERSED_CLIENT_ID

objects = {

/* Begin PBXBuildFile section */
C887CB2F78EAA58DC354FAFB /* libPods-FirebaseUIChat.a in Frameworks */ = {isa = PBXBuildFile; fileRef = 585EBE168DE871301F5FA598 /* libPods-FirebaseUIChat.a */; };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run pod deintegrate to get rid of the CoocaPods artifacts in the project.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. 👍 fix it : abbd453

@asciimike
Copy link
Contributor

Thanks for the PR! I'd prefer we not delete the Database example, so we should either show all of the components in a single example, or we should create two examples (one for Auth, one for DB). Eventually we'll have more modules (Storage, etc.), so I have some concerns about creating n examples, though on the flip side, creating and maintaining a mega example may be pretty difficult.

For now, I'd prefer we revert the deletions of the DB code and go for a single example, but I'm open to a discussion on this point.

@dakeshi
Copy link
Contributor Author

dakeshi commented Jul 5, 2016

Thanks for the PR!

It's my pleasure. Thanks.

For now, I'd prefer we revert the deletions of the DB code and go for a single example, but I'm open to a discussion on this point.

I tried to keep the example structure as much as possible.
But there are two reasons to create the new example focused on the authUI.

First, it is more natural for the user context.
In my case, I find out FirebaseUI in the Firebase Authentication documentation page
It looks like FirebaseUI is a kind of authentication UI library according to the description in key functions section. If some users select their preferred platform, such as iOS,
and move to the project page, what they want to see? AuthUI.
If an example shows auth and database in the same time,
users need to see more documents to understand the example source.
So, I think that it is better to separate examples for auth and database if you want to keep database source.

Second, there are already a good example code for databaseUI in quickstart-ios/database

@asciimike
Copy link
Contributor

Ok, thanks for the rationale for the decision. Let me talk with some folks on the team--it's likely that we'll want to update quickstart-ios/auth to include FirebaseUI/Auth (since if that's what we're doing in the DB, it would make sense to do this with Auth), in which case this sample should include all FirebaseUI components, and we tell people to try the quickstarts for individual pieces.

@asciimike
Copy link
Contributor

Talked with the team (@puf, @samtstern, @AbeHaskins) and we think that the best way to present FirebaseUI will be to:

  • Keep the example app here a "Catalog" type app (similar to UIKitCatalog and what our Android example app is)
  • Use the local source rather than shipped dependencies for the example app, to aid in local development
  • Have the quickstart apps use FirebaseUI where appropriate
  • Update the docs in this repo to add detailed DB documentation, so Auth isn't the only thing here.

@asciimike
Copy link
Contributor

Updated docs in #84

@dakeshi
Copy link
Contributor Author

dakeshi commented Jul 13, 2016

Great feedback. Thank you and your team to have an interest about this issue 👍

Use the local source rather than shipped dependencies for the example app, to aid in local development

Nice approach. I think that my podspec can be a reference for this issue even though it is based on CocoaPods 1.0.0 not 0.39(#79)

Have the quickstart apps use FirebaseUI where appropriate

Good news. 💯

Update the docs in this repo to add detailed DB documentation, so Auth isn't the only thing

In addtion to database docs in this repo, I think that it is a good idea to mention FirebaseUI for database in database intro page like auth doc does

So, how should I do this PR? Close or reverting it for the original source? Because you'll make the new example, reverting old source code would be useless and my podspec need to be test of its syntax on 0.39. Thoughts?

@dakeshi
Copy link
Contributor Author

dakeshi commented Aug 2, 2016

refer to #89, #95

@dakeshi dakeshi closed this Aug 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants