-
Notifications
You must be signed in to change notification settings - Fork 488
Create the new example #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| objects = { | ||
|
|
||
| /* Begin PBXBuildFile section */ | ||
| C887CB2F78EAA58DC354FAFB /* libPods-FirebaseUIChat.a in Frameworks */ = {isa = PBXBuildFile; fileRef = 585EBE168DE871301F5FA598 /* libPods-FirebaseUIChat.a */; }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run pod deintegrate to get rid of the CoocaPods artifacts in the project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch. 👍 fix it : abbd453
|
Thanks for the PR! I'd prefer we not delete the Database example, so we should either show all of the components in a single example, or we should create two examples (one for Auth, one for DB). Eventually we'll have more modules (Storage, etc.), so I have some concerns about creating n examples, though on the flip side, creating and maintaining a mega example may be pretty difficult. For now, I'd prefer we revert the deletions of the DB code and go for a single example, but I'm open to a discussion on this point. |
It's my pleasure. Thanks.
I tried to keep the example structure as much as possible. First, it is more natural for the user context. Second, there are already a good example code for databaseUI in quickstart-ios/database |
|
Ok, thanks for the rationale for the decision. Let me talk with some folks on the team--it's likely that we'll want to update quickstart-ios/auth to include FirebaseUI/Auth (since if that's what we're doing in the DB, it would make sense to do this with Auth), in which case this sample should include all FirebaseUI components, and we tell people to try the quickstarts for individual pieces. |
|
Talked with the team (@puf, @samtstern, @AbeHaskins) and we think that the best way to present FirebaseUI will be to:
|
|
Updated docs in #84 |
|
Great feedback. Thank you and your team to have an interest about this issue 👍
Nice approach. I think that my podspec can be a reference for this issue even though it is based on CocoaPods 1.0.0 not 0.39(#79)
Good news. 💯
In addtion to database docs in this repo, I think that it is a good idea to mention FirebaseUI for database in database intro page like auth doc does So, how should I do this PR? Close or reverting it for the original source? Because you'll make the new example, reverting old source code would be useless and my podspec need to be test of its syntax on 0.39. Thoughts? |
I make PR to solve #75, #67 issues.
Add podspec for local dev
Create new example project