-
Notifications
You must be signed in to change notification settings - Fork 488
Auth sample #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auth sample #95
Changes from all commits
c59d222
7931b52
8219bfa
8d4b15d
4c4bc3d
61c27ff
5eb8b23
2bf405c
34ffeb9
100b7aa
6048ac0
269ab4e
f69e7d8
4a2ba8f
50cd902
86c112d
7fed452
d80c5c5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,6 +2,13 @@ | |
| <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> | ||
| <plist version="1.0"> | ||
| <dict> | ||
| <key>LSApplicationQueriesSchemes</key> | ||
| <array> | ||
| <string>fbapi</string> | ||
| <string>fb-messenger-api</string> | ||
| <string>fbauth2</string> | ||
| <string>fbshareextension</string> | ||
| </array> | ||
| <key>CFBundleDevelopmentRegion</key> | ||
| <string>en</string> | ||
| <key>CFBundleExecutable</key> | ||
|
|
@@ -18,6 +25,25 @@ | |
| <string>1.0</string> | ||
| <key>CFBundleSignature</key> | ||
| <string>????</string> | ||
| <key>CFBundleURLTypes</key> | ||
| <array> | ||
| <dict> | ||
| <key>CFBundleTypeRole</key> | ||
| <string>Editor</string> | ||
| <key>CFBundleURLSchemes</key> | ||
| <array> | ||
| <string>REVERSED_CLIENT_ID</string> | ||
| </array> | ||
| </dict> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Facebook login needs custom URL schemes and LSApplicationQueriesSchemes. it looks like the following:
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. added, thanks! |
||
| <dict> | ||
| <key>CFBundleTypeRole</key> | ||
| <string>Editor</string> | ||
| <key>CFBundleURLSchemes</key> | ||
| <array> | ||
| <string>FACEBOOK_APP_ID</string> | ||
| </array> | ||
| </dict> | ||
| </array> | ||
| <key>CFBundleVersion</key> | ||
| <string>1</string> | ||
| <key>LSRequiresIPhoneOS</key> | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely resolve this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's termsOfServiceURL in pod version of objc source too. Most likely pod version and github versions are not the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good find! Yeah, we should fix this then, and make sure we're testing against the source version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want the sample to be against the source version? Pod version is going to be what everyone encounters as they start using the lib.