Prefer Google auth library and generated API client for list releases action #307
Conversation
| UI.success("✅ Latest release fetched successfully. Returning release and setting Actions.lane_context[SharedValues::FIREBASE_APP_DISTRO_LATEST_RELEASE].") | ||
| end | ||
| Actions.lane_context[SharedValues::FIREBASE_APP_DISTRO_LATEST_RELEASE] = latest_release | ||
| return latest_release | ||
| end | ||
|
|
||
| def self.map_release_hash(release) |
There was a problem hiding this comment.
is this for backwards compatibility, because other fastlane plugins might rely on camelCase instead of snake_case?
Or is this temporary until you update the rest of the code?
There was a problem hiding this comment.
For backwards compatibility
| def refresh_token_from_firebase_tools | ||
| config_path = format_config_path | ||
| if File.exist?(config_path) | ||
| begin | ||
| firebase_tools_tokens = JSON.parse(File.read(config_path))['tokens'] | ||
| if firebase_tools_tokens.nil? | ||
| UI.user_error!(ErrorMessage::EMPTY_TOKENS_FIELD) |
There was a problem hiding this comment.
I might move this to a separate PR. I realized that this isn't actually an exceptional case. If they log out of the Firebase CLI (at least the version I'm using), that file will still exist it just won't have a tokens field. In that case we just want to return nil and continue.
Either. If we want to collaborate on this then I think splitting it up makes sense. The only downside of that is that we'd probably want to temporarily support both paths in the auth client. In this PR I am breaking the old path. |
tagboola
changed the title
Use Google Auth library for application default credentials and use generated API client instead of hand rolled client in the list releases action.