Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add .ConfigureAwait(false) to all async call #109

Merged
merged 1 commit into from Aug 30, 2019

Conversation

@NiCoTinEz
Copy link
Contributor

commented Aug 30, 2019

RELEASE NOTE: Fixed an issue that caused async API calls to deadlock in some environments.

Resolves #108

@googlebot

This comment has been minimized.

Copy link

commented Aug 30, 2019

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@NiCoTinEz

This comment has been minimized.

Copy link
Contributor Author

commented Aug 30, 2019

@googlebot I fixed it.

@googlebot

This comment has been minimized.

Copy link

commented Aug 30, 2019

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link
Member

left a comment

LGTM. Thanks @NiCoTinEz

@hiranya911 hiranya911 changed the title Add .ConfigureAwait(false) to all async call fix: Add .ConfigureAwait(false) to all async call Aug 30, 2019
@hiranya911 hiranya911 self-assigned this Aug 30, 2019
@hiranya911 hiranya911 merged commit e9c8cad into firebase:master Aug 30, 2019
2 checks passed
2 checks passed
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.