Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding golang 1.13 to the CI matrix #294

Merged
merged 4 commits into from Nov 6, 2019
Merged

Conversation

@shogo82148
Copy link
Contributor

shogo82148 commented Nov 5, 2019

Latest Go release is v1.13

RELEASE NOTE: Dropped support for Go 1.9 and 1.10. Go Admin SDK now requires Go 1.11 or higher.

Copy link
Member

hiranya911 left a comment

Thanks for doing this. Let's align with the Google Cloud Go clients, and bump our minimum requirement to go 1.11.

Also change the base branch to dev.

.travis.yml Outdated Show resolved Hide resolved
README.md Outdated
@@ -43,7 +43,7 @@ requests, code review feedback, and also pull requests.

We support Go v1.9 and higher.

This comment has been minimized.

Copy link
@hiranya911

hiranya911 Nov 5, 2019

Member

Let's change to 1.11.

@shogo82148 shogo82148 changed the base branch from master to dev Nov 5, 2019
shogo82148 added 3 commits Nov 5, 2019
@shogo82148 shogo82148 requested a review from hiranya911 Nov 6, 2019
@shogo82148

This comment has been minimized.

Copy link
Contributor Author

shogo82148 commented Nov 6, 2019

Thank you for your review. I fixed it.
Please review it again!

Copy link
Member

hiranya911 left a comment

LGTM 👍

@hiranya911 hiranya911 changed the title Adding golang 1.13 to the CI matrix feat: Adding golang 1.13 to the CI matrix Nov 6, 2019
@hiranya911 hiranya911 self-assigned this Nov 6, 2019
@hiranya911 hiranya911 merged commit 874c9df into firebase:dev Nov 6, 2019
2 checks passed
2 checks passed
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.