Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rc): Add missing class in RemoteConfig Namespace #996

Merged
merged 1 commit into from Aug 17, 2020

Conversation

CodingAleCR
Copy link
Contributor

@CodingAleCR CodingAleCR commented Aug 16, 2020

Just added a class that was missing from the Remote Config Namespace.

RELEASE NOTE: Added missing type definition for ListVersionsOptions.

Just added a class that was missing from the RemoteConfig Namespace.
@googlebot
Copy link

googlebot commented Aug 16, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@CodingAleCR
Copy link
Contributor Author

CodingAleCR commented Aug 16, 2020

@googlebot I signed it!

@googlebot
Copy link

googlebot commented Aug 16, 2020

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@lahirumaramba lahirumaramba self-assigned this Aug 17, 2020
@lahirumaramba lahirumaramba self-requested a review Aug 17, 2020
@lahirumaramba
Copy link
Member

lahirumaramba commented Aug 17, 2020

Thank you @CodingAleCR for submitting this change!

Copy link
Member

@lahirumaramba lahirumaramba left a comment

LGTM!

@lahirumaramba lahirumaramba changed the title Add missing class in RemoteConfig Namespace fix(rc): Add missing class in RemoteConfig Namespace Aug 17, 2020
@lahirumaramba lahirumaramba merged commit 7a5ba24 into firebase:master Aug 17, 2020
6 checks passed
@lahirumaramba
Copy link
Member

lahirumaramba commented Aug 20, 2020

Thank you, @CodingAleCR! This fix is now available in v9.1.1

@CodingAleCR
Copy link
Contributor Author

CodingAleCR commented Aug 20, 2020

Thanks to you for the overview 🎉🙌🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants