Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating Auth API to the new Identity Toolkit endpoint #256

Merged
merged 5 commits into from Feb 7, 2019

Conversation

@hardikns
Copy link
Contributor

commented Feb 4, 2019

Using the new Identity Toolkit REST endpoint for user management features. This is as per corresponding change in java (firebase/firebase-admin-java#220) and node SDKs.

@hardikns hardikns force-pushed the hardikns:hs_new_id_toolkit branch from c3ae524 to 056c3e2 Feb 4, 2019

@hardikns hardikns closed this Feb 4, 2019

@hardikns hardikns reopened this Feb 4, 2019

@hardikns

This comment has been minimized.

Copy link
Contributor Author

commented Feb 4, 2019

@hiranya911 Can you please help on how to run Integration tests? I would like to do those before I submit the PR.

Specifically on what are the contents of the --cert (is this the standard service account json?) and --apikey file.

@hiranya911

This comment has been minimized.

Copy link
Member

commented Feb 4, 2019

@hardikns Check the CONTRIBUTING.md file for instructions.

hardikns added some commits Feb 4, 2019

@hardikns hardikns force-pushed the hardikns:hs_new_id_toolkit branch from ccc7931 to 73872c1 Feb 5, 2019

@hardikns

This comment has been minimized.

Copy link
Contributor Author

commented Feb 6, 2019

@hiranya911 Can you please review the change? I plan to submit another in few days with changes around ooblink.

Meanwhile I did not find any documentation of the new Identity Toolkit. If you can point to the same that would help.

@hiranya911

This comment has been minimized.

Copy link
Member

commented Feb 6, 2019

@hardikns thanks for doing this. I will review this sometime this week.

@bojeil-google any pointers to the documentation of the new ID toolkit API?

@hiranya911 hiranya911 self-assigned this Feb 6, 2019

@hiranya911
Copy link
Member

left a comment

Looks pretty solid. Just a couple of minor changes needed.

CHANGELOG.md Outdated Show resolved Hide resolved
firebase_admin/auth.py Outdated Show resolved Hide resolved
tests/test_user_mgt.py Outdated Show resolved Hide resolved
@hiranya911
Copy link
Member

left a comment

LGTM. Thanks @hardikns for the contribution.

@hiranya911 hiranya911 merged commit 32d7dcd into firebase:master Feb 7, 2019

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@hardikns hardikns deleted the hardikns:hs_new_id_toolkit branch Feb 13, 2019

@hardikns

This comment has been minimized.

Copy link
Contributor Author

commented Feb 13, 2019

@bojeil-google can you please point me to the documentation on the new ID toolkit API?

@bojeil-google

This comment has been minimized.

Copy link
Member

commented Feb 13, 2019

If you mean the REST API, it is not yet documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.