Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fcm): Analytics label based on @chemidy #310

Merged
merged 7 commits into from Jul 19, 2019
Merged

feat(fcm): Analytics label based on @chemidy #310

merged 7 commits into from Jul 19, 2019

Conversation

@willawang8908
Copy link
Contributor

@willawang8908 willawang8908 commented Jul 19, 2019

#301

RELEASE NOTE: Added support for specifying the analytics label for notifications.

@googlebot
Copy link

@googlebot googlebot commented Jul 19, 2019

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Loading

@willawang8908
Copy link
Contributor Author

@willawang8908 willawang8908 commented Jul 19, 2019

I signed it!

Loading

@googlebot
Copy link

@googlebot googlebot commented Jul 19, 2019

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

Loading

@willawang8908
Copy link
Contributor Author

@willawang8908 willawang8908 commented Jul 19, 2019

@googlebot I consent.

Loading

Copy link
Member

@hiranya911 hiranya911 left a comment

Thanks @willawang8908. Code looks good.

@chemidy can you put a comment indicating your consent, so we can proceed with this?

Loading

@chemidy
Copy link
Contributor

@chemidy chemidy commented Jul 19, 2019

Of course i'm ok with that you can merge it.

Loading

@hiranya911
Copy link
Member

@hiranya911 hiranya911 commented Jul 19, 2019

@chemidy You need to put a comment with the text @googlebot I consent

Loading

@chemidy
Copy link
Contributor

@chemidy chemidy commented Jul 19, 2019

@googlebot I consent

Loading

@googlebot
Copy link

@googlebot googlebot commented Jul 19, 2019

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Loading

@hiranya911 hiranya911 self-assigned this Jul 19, 2019
@hiranya911
Copy link
Member

@hiranya911 hiranya911 commented Jul 19, 2019

Closes #303

Loading

@hiranya911 hiranya911 merged commit 8cf7291 into firebase:master Jul 19, 2019
2 checks passed
Loading
@hiranya911 hiranya911 changed the title Analytics label based on @chemidy feat(fcm): Analytics label based on @chemidy Aug 13, 2019
@stripathi669
Copy link

@stripathi669 stripathi669 commented Aug 14, 2019

@hiranya911 Can I check - when might you be planning to release this?

Loading

@hiranya911
Copy link
Member

@hiranya911 hiranya911 commented Aug 14, 2019

Most likely next week.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants