Implementing App Default and Refresh Token Credential Types #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 27, 2017 19:06
…ce it does not work on python 3.
jwngr
suggested changes
Mar 28, 2017
firebase_admin/credentials.py
Outdated
|
|
||
|
|
||
| class ApplicationDefault(Base): | ||
| """A Google application default credential.""" |
There was a problem hiding this comment.
Nit: capitalize "Application" and "Default" (multiple places in this file).
firebase_admin/credentials.py
Outdated
| """A credential initialized from an existing refresh token.""" | ||
|
|
||
| def __init__(self, file_path): | ||
| """Initialized a refresh token credential from the specified JSON file. |
tests/test_credentials.py
Outdated
| credentials._http = testutils.HttpMock(200, json.dumps(mock_response)) | ||
| access_token = credential.get_access_token() | ||
| assert access_token.access_token == 'mock_access_token' | ||
| assert access_token.expires_in <= 1234 |
There was a problem hiding this comment.
Why is this <= instead of ==? If it's non-obvious, please leave a comment.
There was a problem hiding this comment.
This is because GoogleCredentials class recalculates the expires_in property before returning. Added a comment to mention that.
|
Made the suggested changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.