Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase number of retries before deleting events #1708

Merged
merged 1 commit into from Jun 23, 2020

Conversation

mrwillis21
Copy link
Contributor

@mrwillis21 mrwillis21 commented Jun 23, 2020

The current retry logic will delete an event after 10 retries,
which will only take ~17 minutes for high priority events.
If a device is on a bad network for that period of time, we could
relatively easily lose these events.

Increasing this to 16 will extend this timeframe to ~18 hours,
giving more opportunity for a retry to occur when the device has
a better network connection.

The current retry logic will delete an event after 10 retries,
which will only take ~17 minutes. If a device is on a bad network
for that period of time, we could relatively easily lose events.

Increasing this to 16 will extend this timeframe to ~18 hours,
giving more opportunity for a retry to occur when the device has
a better network connection.
@googlebot googlebot added the cla: yes Override cla label Jun 23, 2020
@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • transport-api

    Type Base (08507fa) Head (b63de82e) Diff
    apk (aggressive) 11.0 kB 10.9 kB -21 B (-0.2%)
    apk (debug) 23.0 kB 23.0 kB -2 B (-0.0%)
  • transport-runtime

    Type Base (08507fa) Head (b63de82e) Diff
    aar 127 kB 127 kB -4 B (-0.0%)
    apk (debug) 80.6 kB 80.6 kB -11 B (-0.0%)

Test Logs

Notes

Head commit (b63de82e) is created by Prow via merging commits: 08507fa f6dffed.

@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

No changes between base commit (08507fa) and head commit (b63de82e).

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (b63de82e) is created by Prow via merging commits: 08507fa f6dffed.

@mrwillis21 mrwillis21 merged commit 59db590 into master Jun 23, 2020
@mrwillis21 mrwillis21 deleted the increase-firelog-retries branch June 23, 2020 21:07
@firebase firebase locked and limited conversation to collaborators Jul 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants