Fireperf: create a random delay before initiating a remote config fetch. #2968
Conversation
Coverage ReportAffected SDKs
Test Logs
NotesHTML coverage reports can be produced locally with Head commit (44dc407b) is created by Prow via merging commits: b9f0ab6 b255861. |
Binary Size ReportAffected SDKs
Test Logs
NotesHead commit (44dc407b) is created by Prow via merging commits: b9f0ab6 b255861. |
|
/retest |
visumickey
left a comment
There was a problem hiding this comment.
Thanks for making this change @leotianlizhan. Glad to see the changes. I have few comments. PTAL as it permits.
|
/retest |
visumickey
left a comment
There was a problem hiding this comment.
This is great! Thanks for making the changes Leo.
How are you planning to test this? It is important to do some manual testing to make sure we are able fetch the configs in less than 30 seconds and greater than 5 seconds. If you are able to ascertain that, please feel free to merge this change.
2212970 to
b255861
Compare
yes I've done some manual testing and it looks like it works |
Rationale:
This is required to ensure that a remote notification does not trigger multiple config fetches from remote config at the same time. Internal bug reference: b/187985523
iOS version of the same change firebase/firebase-ios-sdk#8593