Clean up FieldValueTests #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikelehen
approved these changes
May 16, 2019
There was a problem hiding this comment.
Nice. I think there's still a bit of fuzziness in that most of the (now-)UserDataConverter tests also test FieldValue.value() (i.e. the full round-trip from value => FieldValue => value) which isn't done by UserDataConverter but I don't think it's worth trying to split that apart.
| @@ -37,7 +38,7 @@ | |||
| @PublicApi | |||
| public final class Timestamp implements Comparable<Timestamp>, Parcelable { | |||
|
|
|||
| @PublicApi | |||
| @PublicApi @NonNull | |||
There was a problem hiding this comment.
I had a newline here but googleJavaFormat eated it.
|
/retest |
1 similar comment
|
/retest |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorganize to make things clearer:
UserDataConverterinto aUserDataConverterTest.FieldValueintoTimestampTestAlso fix nullability annotations on
Timestamp.