Use find_program to get python in cmake #1156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dconeybe
reviewed
Nov 24, 2022
|
|
||
| set(FIREBASE_PYTHON_EXECUTABLE "python" CACHE FILEPATH | ||
| "The Python interpreter to use, such as one from a venv") | ||
| find_program(FIREBASE_PYTHON_EXECUTABLE |
Contributor
There was a problem hiding this comment.
Can this still be overridden by specifying -D FIREBASE_PYTHON_EXECUTABLE=xxx? I depend on that functionality.
Contributor
Author
There was a problem hiding this comment.
Yep, documentation suggested that, and confirmed it locally.
a-maurice
added
the
tests-requested: quick
github-actions
bot
added
tests: in-progress
Integration test with FLAKINESS (succeeded after retry)Requested by @a-maurice on commit 9516fcd
Add flaky tests to go/fpl-cpp-flake-tracker |
github-actions
bot
added
the
tests: succeeded
firebase-workflow-trigger
bot
removed
the
tests: in-progress
cynthiajoan
approved these changes
Nov 29, 2022
Contributor
Author
|
The failing test is an unrelated issue, that I will fix in a different PR. |
github-actions
bot
added
tests: in-progress
firebase-workflow-trigger
bot
removed
the
tests: in-progress
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of using set, we should use find_program to locate the python executable, since it can either be python or python3.
Testing
Type of Change
Place an
xthe applicable box:Notes
Release Notessection ofrelease_build_files/readme.md.