From 3e726458edc6fe1cf64e5a0cf9fc2f7f703ec60b Mon Sep 17 00:00:00 2001 From: a-maurice Date: Tue, 6 Jun 2023 16:54:57 -0700 Subject: [PATCH] Fix App Check on 32 bit desktop --- app_check/src/desktop/app_check_desktop.cc | 5 +++-- release_build_files/readme.md | 1 + 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/app_check/src/desktop/app_check_desktop.cc b/app_check/src/desktop/app_check_desktop.cc index f46f908177..9fc7cf48ea 100644 --- a/app_check/src/desktop/app_check_desktop.cc +++ b/app_check/src/desktop/app_check_desktop.cc @@ -53,8 +53,9 @@ ReferenceCountedFutureImpl* AppCheckInternal::future() { } bool AppCheckInternal::HasValidCacheToken() const { - // Get the current time, in milliseconds - int64_t current_time = std::time(nullptr) * 1000; + // Get the current time, in milliseconds (Done in two lines because of x86) + int64_t current_time = std::time(nullptr); + current_time *= 1000; // TODO(amaurice): Add some additional time to the check return cached_token_.expire_time_millis > current_time; } diff --git a/release_build_files/readme.md b/release_build_files/readme.md index 9d8fd15df6..e5f279725a 100644 --- a/release_build_files/readme.md +++ b/release_build_files/readme.md @@ -629,6 +629,7 @@ code. ## Release Notes ### Upcoming Release - Changes + - App Check (Desktop): Fixed expired tokens being cached on 32-bit systems. - Remote Config (Desktop): Fixed handling of time zones on Windows when the time zone name in the current system language contains an accented character or apostrophe. This adds a requirement for applications using