Skip to content

Fix App Check on 32 bit desktop #1341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Fix App Check on 32 bit desktop #1341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions app_check/src/desktop/app_check_desktop.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,9 @@ ReferenceCountedFutureImpl* AppCheckInternal::future() {
}

bool AppCheckInternal::HasValidCacheToken() const {
// Get the current time, in milliseconds
int64_t current_time = std::time(nullptr) * 1000;
// Get the current time, in milliseconds (Done in two lines because of x86)
int64_t current_time = std::time(nullptr);
current_time *= 1000;
// TODO(amaurice): Add some additional time to the check
return cached_token_.expire_time_millis > current_time;
}
Expand Down
1 change: 1 addition & 0 deletions release_build_files/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -629,6 +629,7 @@ code.
## Release Notes
### Upcoming Release
- Changes
- App Check (Desktop): Fixed expired tokens being cached on 32-bit systems.
- Remote Config (Desktop): Fixed handling of time zones on Windows when the
time zone name in the current system language contains an accented
character or apostrophe. This adds a requirement for applications using
Expand Down