Skip to content

Firestore: integration_test_internal/build.gradle: improvements for local dev: targets and abiFilters #1344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Jun 9, 2023

Improve the local development build times for the Firestore integration tests on Android by (a) specifying targets to only build the required cmake targets and (b) specifying abiFilters conveniently in local.properties to only compile the ABI that is actually needed for local development (e.g. "x86", "x86_64", "arm64-v8a").

@dconeybe dconeybe self-assigned this Jun 9, 2023
@dconeybe dconeybe added skip-release-notes Skip release notes check tests-requested: quick Trigger a quick set of integration tests. labels Jun 9, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jun 9, 2023
@github-actions
Copy link

github-actions bot commented Jun 9, 2023

Integration test with FLAKINESS (succeeded after retry)

Requested by @wu-hui on commit a671c46
Last updated: Fri Jun 16 12:12 PDT 2023
View integration test log & download artifacts

Failures Configs
firestore [TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: emulator_ftl_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Jun 9, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 9, 2023
@dconeybe dconeybe requested a review from wu-hui June 9, 2023 20:28
@wu-hui wu-hui merged commit a671c46 into main Jun 16, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests: succeeded This PR's integration tests succeeded. labels Jun 16, 2023
@dconeybe dconeybe deleted the dconeybe/GradleBuildOptimizationsForLocalDev branch June 16, 2023 18:15
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Jun 16, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 16, 2023
@firebase firebase locked and limited conversation to collaborators Jul 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: firestore skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants