Skip to content

Internal updates #1349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 23, 2023
Merged

Internal updates #1349

merged 8 commits into from
Jun 23, 2023

Conversation

@nakirekommula
Copy link
Contributor

@nakirekommula nakirekommula commented Jun 12, 2023

Description

Experimental changes.

Testing

None.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

None.

@nakirekommula nakirekommula added tests-requested: quick Trigger a quick set of integration tests. skip-release-notes Skip release notes check labels Jun 12, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jun 12, 2023
@github-actions
Copy link

github-actions bot commented Jun 12, 2023 •
edited
Loading

Integration test with FLAKINESS (succeeded after retry)

Requested by @nakirekommula on commit 9723100
Last updated: Fri Jun 23 16:16 PDT 2023
View integration test log & download artifacts

Failures Configs
firestore [TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT
messaging [TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

nakirekommula
nakirekommula commented Jun 12, 2023
View reviewed changes
nakirekommula
nakirekommula commented Jun 12, 2023
View reviewed changes
@nakirekommula nakirekommula added tests-requested: quick Trigger a quick set of integration tests. and removed tests: in-progress This PR's integration tests are in progress. labels Jun 12, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jun 12, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 13, 2023
berile
berile approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@berile berile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Some minor suggestions. Thank you!

@nakirekommula
Copy link
Contributor Author

nakirekommula commented Jun 13, 2023

LGTM! Some minor suggestions. Thank you!

Thanks for the review! Addressed the comments in a new commit.

jonsimantov
jonsimantov approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@jonsimantov jonsimantov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few nits/questions.

@nakirekommula
Copy link
Contributor Author

nakirekommula commented Jun 22, 2023

Looks good, just a few nits/questions.

Thanks for the review Jon! Added responses to the comments. PTAL and let me know.

DellaBitta
DellaBitta requested changes Jun 23, 2023
View reviewed changes
Copy link
Contributor

@DellaBitta DellaBitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a rare code path that leaves a hanging jobject reference.

@nakirekommula
Copy link
Contributor Author

nakirekommula commented Jun 23, 2023

There's a rare code path that leaves a hanging jobject reference.

Thanks for the review David! Addressed the comments in the latest commit.

@nakirekommula nakirekommula requested a review from DellaBitta June 23, 2023 15:06
DellaBitta
DellaBitta reviewed Jun 23, 2023
View reviewed changes
DellaBitta
DellaBitta reviewed Jun 23, 2023
View reviewed changes
DellaBitta
DellaBitta approved these changes Jun 23, 2023
View reviewed changes
Copy link
Contributor

@DellaBitta DellaBitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with some last nit comments!

@nakirekommula
Copy link
Contributor Author

nakirekommula commented Jun 23, 2023

Approved with some last nit comments!

Thanks again!

@nakirekommula nakirekommula merged commit 9723100 into main Jun 23, 2023
@nakirekommula nakirekommula deleted the feature/gma_native_2023_5 branch June 23, 2023 20:51
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests: succeeded This PR's integration tests succeeded. labels Jun 23, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 23, 2023
@firebase firebase locked and limited conversation to collaborators Jul 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DellaBitta DellaBitta DellaBitta approved these changes

@berile berile berile approved these changes

+1 more reviewer

@jonsimantov jonsimantov jonsimantov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nakirekommula @jonsimantov @DellaBitta @berile