Skip to content

Run iOS simulator install as root #1379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2023
Merged

Run iOS simulator install as root #1379

merged 1 commit into from
Jun 30, 2023

Conversation

@a-maurice
Copy link
Contributor

@a-maurice a-maurice commented Jun 30, 2023

Description

Provide details of the change, and generalize the change in the PR title above.

The xcodes install can fail when not run as root, so do so.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@a-maurice a-maurice added skip-release-notes Skip release notes check tests-requested: quick Trigger a quick set of integration tests. labels Jun 30, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jun 30, 2023
@github-actions
Copy link

github-actions bot commented Jun 30, 2023 •
edited
Loading

Integration test with FLAKINESS (succeeded after retry)

Requested by @a-maurice on commit d916083
Last updated: Fri Jun 30 18:07 PDT 2023
View integration test log & download artifacts

Failures Configs
gma [TEST] [FLAKINESS] [iOS] [macos] [1/2 ios_device: ios_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

jonsimantov
jonsimantov reviewed Jun 30, 2023
View reviewed changes
scripts/gha/test_simulator.py
device_os = available_versions[-1]

args = ["xcodes", "runtimes", "install", "%s %s" % (apple_platform, device_os)]
args = ["sudo", "xcodes", "runtimes", "install", "%s %s" % (apple_platform, device_os)]
Copy link
Contributor

@jonsimantov jonsimantov Jun 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the info log message below to say it uses sudo; that way, if a user is running this on their machine, they won't be surprised by the password prompt.

Copy link
Contributor Author

@a-maurice a-maurice Jun 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It prints out the args array, so the sudo should be included in the message

Copy link
Contributor

@jonsimantov jonsimantov Jun 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that's fine, though not quite as user-friendly as it could be. :P

@jonsimantov jonsimantov self-requested a review June 30, 2023 18:58
jonsimantov
jonsimantov approved these changes Jun 30, 2023
View reviewed changes
scripts/gha/test_simulator.py
device_os = available_versions[-1]

args = ["xcodes", "runtimes", "install", "%s %s" % (apple_platform, device_os)]
args = ["sudo", "xcodes", "runtimes", "install", "%s %s" % (apple_platform, device_os)]
Copy link
Contributor

@jonsimantov jonsimantov Jun 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that's fine, though not quite as user-friendly as it could be. :P

@jonsimantov
Copy link
Contributor

jonsimantov commented Jun 30, 2023

BTW the time this failed was when I ran "full" tests so you might need to do that...

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Jun 30, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 30, 2023
@a-maurice a-maurice merged commit d916083 into main Jun 30, 2023
@a-maurice a-maurice deleted the am-ios_installs branch June 30, 2023 22:23
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests: succeeded This PR's integration tests succeeded. labels Jun 30, 2023
@a-maurice a-maurice mentioned this pull request Jun 30, 2023
Merged
3 tasks
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Jul 1, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jul 1, 2023
tom-andersen pushed a commit that referenced this pull request Jul 17, 2023
@a-maurice @tom-andersen
Run simulator install as root (#1379)
9414f70
@firebase firebase locked and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jonsimantov jonsimantov jonsimantov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@a-maurice @jonsimantov