Trigger integration tests by setting a "tests-requested" label. #339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsimantov
added
tests-requested: quick
github-actions
bot
removed
tests-requested: quick
firebase-workflow-trigger
bot
removed
the
tests: in-progress
jonsimantov
added
the
tests-requested: quick
github-actions
bot
added
tests: in-progress
firebase-workflow-trigger
bot
removed
the
tests: in-progress
jonsimantov
added
the
tests-requested: quick
github-actions
bot
added
tests: in-progress
jonsimantov
added
the
tests-requested: quick
github-actions
bot
removed
tests-requested: quick
❌ Integration test FAILEDRequested by @jonsimantov on commit 8847940 |
DellaBitta
approved these changes
Mar 19, 2021
Contributor
DellaBitta
left a comment
DellaBitta
left a comment
There was a problem hiding this comment.
Guess you need the 0 fetch after all, eh? :)
👍
firebase-workflow-trigger
bot
removed
the
tests: in-progress
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some label-based triggers for integration tests, which allow the integration tests to be requested on a PR by setting the "tests-requested" label.
There are two modes for requesting tests, "quick" and "full":
"quick" tries to be clever and figure out a subset of APIs (and even platforms) to test. This heuristic is really simple right now (it just looks at directory names and, for platform, filenames) and if there is any ambiguity it will just run the normal suite of tests.
"full" just runs all the tests. Currently this is set to use an expanded test matrix, though this could be changed in the future.
The test workflow handles updating the labels and posting/updating a comment with the status of the integration tests as they run. All of the jobs that mess with labels and comments are skipped if the workflow wasn't run from the PR label.
(See #337—which won't be merged—for an example of "quick" mode in action, autodetecting to just run a subset of tests.)