Feature/tvos support integration tests storage #470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vimanyu
added
the
tests-requested: quick
github-actions
bot
added
tests: in-progress
✅ Integration test succeeded!Requested by @vimanyu on commit c6e6816 |
firebase-workflow-trigger
bot
removed
the
tests: in-progress
github-actions
bot
added
the
tests: succeeded
DellaBitta
requested changes
Jun 16, 2021
Contributor
DellaBitta
left a comment
DellaBitta
left a comment
There was a problem hiding this comment.
Remove user specific files:
- storage/integration_test/integration_test.xcodeproj/project.xcworkspace/xcuserdata/vimanyujain.xcuserdatad/UserInterfaceState.xcuserstate
- storage/integration_test/integration_test.xcodeproj/xcuserdata/vimanyujain.xcuserdatad/xcschemes/xcschememanagement.plist
- storage/integration_test/integration_test.xcworkspace/xcuserdata/vimanyujain.xcuserdatad/UserInterfaceState.xcuserstate
Contributor
Author
|
Thanks for pointing it out! Done. |
DellaBitta
approved these changes
Jun 17, 2021
github-actions
bot
added
the
tests: in-progress
❌ Integration test FAILEDRequested by @vimanyu on commit fccb88c
|
github-actions
bot
added
tests: failed
firebase-workflow-trigger
bot
removed
the
tests: in-progress
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes done to XCode project for storage that allows us to run integration tests on device and simulator.
added a tvos target to XCode project for storage.
updated Podfile to build pods for tvos platform for this newly added target
To test this,
Make sure to have a valid GoogleService-Info.plist.
pod install
open integration_test.xcworkspace
Drag and drop firebase.xcframework, firebase_auth.xcframework and firebase_storage.xcframework
All tests pass on simulator but one (TestPutFileAndGetFile) is failing on device ( internal ticket: b/91209621).