From 54c238063302ef14a7c603902433a71d989fd5e0 Mon Sep 17 00:00:00 2001 From: "drsanta@google.com" Date: Tue, 14 Jul 2020 11:32:47 -0400 Subject: [PATCH 01/12] desktop workflow config to create cores, and use upload-artfiacts@v2 --- .github/workflows/desktop.yml | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/.github/workflows/desktop.yml b/.github/workflows/desktop.yml index 89a0f4dba2..c0d5377648 100644 --- a/.github/workflows/desktop.yml +++ b/.github/workflows/desktop.yml @@ -167,5 +167,13 @@ jobs: env: LANG: en_US run: | + ulimit -c unlimited # Enable crash dumps cd build - ctest --verbose + sudo ctest --verbose + sudo chmod -R +rwx /cores/* + + - name: Archive crashes + uses: actions/upload-artifact@v2 + with: + name: crashes + path: /cores \ No newline at end of file From d77f33b1a319bda5653c58c74d09651dc4d82f0d Mon Sep 17 00:00:00 2001 From: "drsanta@google.com" Date: Tue, 14 Jul 2020 11:41:07 -0400 Subject: [PATCH 02/12] test access to cores directory --- .github/workflows/desktop.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/desktop.yml b/.github/workflows/desktop.yml index c0d5377648..6acb1bc80d 100644 --- a/.github/workflows/desktop.yml +++ b/.github/workflows/desktop.yml @@ -163,6 +163,11 @@ jobs: find build -name "*.a" find build -name "*.so" + - name: test access to core dump directory + sudo touch /cores/test + ls /cores + sudo rm /cores/test + - name: Run tests env: LANG: en_US From 4b8441b2c6598b9baa92dd4a6655eca8c6edd4ec Mon Sep 17 00:00:00 2001 From: "drsanta@google.com" Date: Tue, 14 Jul 2020 11:44:01 -0400 Subject: [PATCH 03/12] indentation problem --- .github/workflows/desktop.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/desktop.yml b/.github/workflows/desktop.yml index 6acb1bc80d..51a8a11a20 100644 --- a/.github/workflows/desktop.yml +++ b/.github/workflows/desktop.yml @@ -164,9 +164,9 @@ jobs: find build -name "*.so" - name: test access to core dump directory - sudo touch /cores/test - ls /cores - sudo rm /cores/test + sudo touch /cores/test + ls /cores + sudo rm /cores/test - name: Run tests env: From 67a02a55b32998daae583b558e1a62634fe35a3c Mon Sep 17 00:00:00 2001 From: "drsanta@google.com" Date: Tue, 14 Jul 2020 11:45:08 -0400 Subject: [PATCH 04/12] test cores dir run command --- .github/workflows/desktop.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/desktop.yml b/.github/workflows/desktop.yml index 51a8a11a20..87c91758d0 100644 --- a/.github/workflows/desktop.yml +++ b/.github/workflows/desktop.yml @@ -164,6 +164,7 @@ jobs: find build -name "*.so" - name: test access to core dump directory + run: | sudo touch /cores/test ls /cores sudo rm /cores/test From debc485c9d96af091684945bd74a048263fecb23 Mon Sep 17 00:00:00 2001 From: "drsanta@google.com" Date: Tue, 14 Jul 2020 13:25:32 -0400 Subject: [PATCH 05/12] determining if the crash location is /var/crash --- .github/workflows/desktop.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/desktop.yml b/.github/workflows/desktop.yml index 87c91758d0..1e14157e6d 100644 --- a/.github/workflows/desktop.yml +++ b/.github/workflows/desktop.yml @@ -165,6 +165,10 @@ jobs: - name: test access to core dump directory run: | + ls /var/crash + sudo touch /var/crash/test + ls /var/crash + cat /proc/sys/kernel/core_pattern sudo touch /cores/test ls /cores sudo rm /cores/test From 94a576a423b9448ad75661d39c1e69058ba1eaa0 Mon Sep 17 00:00:00 2001 From: "drsanta@google.com" Date: Tue, 14 Jul 2020 13:53:35 -0400 Subject: [PATCH 06/12] added shell declaration to test --- .github/workflows/desktop.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/desktop.yml b/.github/workflows/desktop.yml index 1e14157e6d..c5367319b1 100644 --- a/.github/workflows/desktop.yml +++ b/.github/workflows/desktop.yml @@ -164,6 +164,7 @@ jobs: find build -name "*.so" - name: test access to core dump directory + shell: bash run: | ls /var/crash sudo touch /var/crash/test From 4a17399a6a73f990d0547495f6fb026976c7f670 Mon Sep 17 00:00:00 2001 From: "drsanta@google.com" Date: Tue, 14 Jul 2020 17:03:18 -0400 Subject: [PATCH 07/12] Continued core path sleuthing --- .github/workflows/desktop.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/desktop.yml b/.github/workflows/desktop.yml index c5367319b1..1ea270f074 100644 --- a/.github/workflows/desktop.yml +++ b/.github/workflows/desktop.yml @@ -166,10 +166,9 @@ jobs: - name: test access to core dump directory shell: bash run: | - ls /var/crash - sudo touch /var/crash/test - ls /var/crash + coredumpctl cat /proc/sys/kernel/core_pattern + ls -l /var/lib/systemd/coredump/ sudo touch /cores/test ls /cores sudo rm /cores/test From 2e0207d1d8d542bdd5d4b614740ff7248351339a Mon Sep 17 00:00:00 2001 From: "drsanta@google.com" Date: Wed, 15 Jul 2020 10:16:17 -0400 Subject: [PATCH 08/12] attempting to query cores directory via cat /proc/sys/kernel/core_pattern --- .github/workflows/desktop.yml | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/.github/workflows/desktop.yml b/.github/workflows/desktop.yml index 1ea270f074..65d148fc64 100644 --- a/.github/workflows/desktop.yml +++ b/.github/workflows/desktop.yml @@ -166,13 +166,8 @@ jobs: - name: test access to core dump directory shell: bash run: | - coredumpctl cat /proc/sys/kernel/core_pattern - ls -l /var/lib/systemd/coredump/ - sudo touch /cores/test - ls /cores - sudo rm /cores/test - + - name: Run tests env: LANG: en_US From 6f411fa0544ad01f31a07341aacd052d75236be4 Mon Sep 17 00:00:00 2001 From: "drsanta@google.com" Date: Wed, 15 Jul 2020 10:23:06 -0400 Subject: [PATCH 09/12] checking for apport crash results directory --- .github/workflows/desktop.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/desktop.yml b/.github/workflows/desktop.yml index 65d148fc64..ad06c1b7f9 100644 --- a/.github/workflows/desktop.yml +++ b/.github/workflows/desktop.yml @@ -167,6 +167,7 @@ jobs: shell: bash run: | cat /proc/sys/kernel/core_pattern + ls -l /var/crash/ - name: Run tests env: From 095206ae149725a5a856edab1492038e9caa68e3 Mon Sep 17 00:00:00 2001 From: "drsanta@google.com" Date: Wed, 15 Jul 2020 10:34:42 -0400 Subject: [PATCH 10/12] updated archive to the /var/crash apport directory --- .github/workflows/desktop.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/desktop.yml b/.github/workflows/desktop.yml index ad06c1b7f9..7ea8ce258e 100644 --- a/.github/workflows/desktop.yml +++ b/.github/workflows/desktop.yml @@ -176,10 +176,10 @@ jobs: ulimit -c unlimited # Enable crash dumps cd build sudo ctest --verbose - sudo chmod -R +rwx /cores/* + sudo chmod -R +rwx /var/crash/* - name: Archive crashes uses: actions/upload-artifact@v2 with: name: crashes - path: /cores \ No newline at end of file + path: /var/crash/ \ No newline at end of file From 4757f8b3452ccec8f5a60a349aee838d669cd774 Mon Sep 17 00:00:00 2001 From: "drsanta@google.com" Date: Wed, 15 Jul 2020 10:42:16 -0400 Subject: [PATCH 11/12] start the apport service --- .github/workflows/desktop.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/desktop.yml b/.github/workflows/desktop.yml index 7ea8ce258e..b9589b3b72 100644 --- a/.github/workflows/desktop.yml +++ b/.github/workflows/desktop.yml @@ -163,11 +163,11 @@ jobs: find build -name "*.a" find build -name "*.so" - - name: test access to core dump directory + - name: enable apport shell: bash run: | - cat /proc/sys/kernel/core_pattern - ls -l /var/crash/ + sudo service apport start + sudo chmod -R +rwx /var/crash/* - name: Run tests env: @@ -176,7 +176,7 @@ jobs: ulimit -c unlimited # Enable crash dumps cd build sudo ctest --verbose - sudo chmod -R +rwx /var/crash/* + - name: Archive crashes uses: actions/upload-artifact@v2 From 2d671071e21b1e8c076890d38590e36067b81551 Mon Sep 17 00:00:00 2001 From: "drsanta@google.com" Date: Wed, 15 Jul 2020 10:48:10 -0400 Subject: [PATCH 12/12] manually create the crash directory --- .github/workflows/desktop.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/desktop.yml b/.github/workflows/desktop.yml index b9589b3b72..28429f456e 100644 --- a/.github/workflows/desktop.yml +++ b/.github/workflows/desktop.yml @@ -167,6 +167,7 @@ jobs: shell: bash run: | sudo service apport start + mkdir /var/crash sudo chmod -R +rwx /var/crash/* - name: Run tests