Error: Error parsing triggers: Cannot find module 'actions-on-google'

[Flypex]

i deploying functions
i functions: ensuring necessary APIs are enabled...

• functions: all necessary APIs are enabled
  i functions: preparing functions directory for uploading...

Error: Error parsing triggers: Cannot find module 'actions-on-google'
Try running "npm install" in your functions directory before deploying.

I don't know how to solve the problem. I have run npm-install in the functions directory, but have had no luck in getting this to work. How can I fix the problem?

[mbleigh]

Make sure that actions-on-google is listed as a dependency in your package.json and then run npm install again.

[HarshHC]

@mbleigh I am getting the same problem and I do have actions-on-google in my package.json.
But when i run npm install i get this:
`npm WARN saveError ENOENT: no such file or directory, open 'C:\users\HarshC\codelabs-nodejs\package.json'
npm WARN enoent ENOENT: no such file or directory, open 'C:\users\HarshC\codelabs-nodejs\package.json'
npm WARN codelabs-nodejs No description
npm WARN codelabs-nodejs No repository field.
npm WARN codelabs-nodejs No README data
npm WARN codelabs-nodejs No license field.

up to date in 17.903s
[!] 21 vulnerabilities found [9838 packages audited]
Severity: 2 Low | 18 Moderate | 1 High
Run npm audit for more detail`

and after running firebase deploy it says cannot find module message again.
Also when I do firebase --version I get the response 3.18.4 however in the codelab it is mentioned we should have it at least 3.5 . but when I checked the repo in github the latest version is 3.18.4.

btw on doing npm audit i get this:
`$ npm audit
npm ERR! code EAUDITNOPJSON
npm ERR! audit No package.json found: Cannot audit a project without a package.json

npm ERR! A complete log of this run can be found in:
npm ERR! C:\Users\HarshC\AppData\Roaming\npm-cache_logs\2018-05-14T12_05_48_599Z-debug.log`

and here is the log:
`0 info it worked if it ends with ok
1 verbose cli [ 'C:\Program Files\nodejs\node.exe',
1 verbose cli 'C:\Users\HarshC\AppData\Roaming\npm\node_modules\npm\bin\npm-cli.js',
1 verbose cli 'audit' ]
2 info using npm@6.0.1
3 info using node@v6.11.2
4 verbose npm-session bb3161783ffb06ed
5 verbose stack Error: No package.json found: Cannot audit a project without a package.json
5 verbose stack at Bluebird.all.spread (C:\Users\HarshC\AppData\Roaming\npm\node_modules\npm\lib\audit.js:59:19)
5 verbose stack at tryCatcher (C:\Users\HarshC\AppData\Roaming\npm\node_modules\npm\node_modules\bluebird\js\release\util.js:16:23)
5 verbose stack at Promise._settlePromiseFromHandler (C:\Users\HarshC\AppData\Roaming\npm\node_modules\npm\node_modules\bluebird\js\release\promise.js:509:35)
5 verbose stack at Promise._settlePromise (C:\Users\HarshC\AppData\Roaming\npm\node_modules\npm\node_modules\bluebird\js\release\promise.js:569:18)
5 verbose stack at Promise._settlePromise0 (C:\Users\HarshC\AppData\Roaming\npm\node_modules\npm\node_modules\bluebird\js\release\promise.js:614:10)
5 verbose stack at Promise._settlePromises (C:\Users\HarshC\AppData\Roaming\npm\node_modules\npm\node_modules\bluebird\js\release\promise.js:693:18)
5 verbose stack at Promise._fulfill (C:\Users\HarshC\AppData\Roaming\npm\node_modules\npm\node_modules\bluebird\js\release\promise.js:638:18)
5 verbose stack at PromiseArray._resolve (C:\Users\HarshC\AppData\Roaming\npm\node_modules\npm\node_modules\bluebird\js\release\promise_array.js:126:19)
5 verbose stack at PromiseArray._promiseFulfilled (C:\Users\HarshC\AppData\Roaming\npm\node_modules\npm\node_modules\bluebird\js\release\promise_array.js:144:14)
5 verbose stack at PromiseArray._iterate (C:\Users\HarshC\AppData\Roaming\npm\node_modules\npm\node_modules\bluebird\js\release\promise_array.js:114:31)
5 verbose stack at PromiseArray.init [as _init] (C:\Users\HarshC\AppData\Roaming\npm\node_modules\npm\node_modules\bluebird\js\release\promise_array.js:78:10)
5 verbose stack at Promise._settlePromise (C:\Users\HarshC\AppData\Roaming\npm\node_modules\npm\node_modules\bluebird\js\release\promise.js:566:21)
5 verbose stack at Promise._settlePromise0 (C:\Users\HarshC\AppData\Roaming\npm\node_modules\npm\node_modules\bluebird\js\release\promise.js:614:10)
5 verbose stack at Promise._settlePromises (C:\Users\HarshC\AppData\Roaming\npm\node_modules\npm\node_modules\bluebird\js\release\promise.js:693:18)
5 verbose stack at Promise._fulfill (C:\Users\HarshC\AppData\Roaming\npm\node_modules\npm\node_modules\bluebird\js\release\promise.js:638:18)
5 verbose stack at PromiseArray._resolve (C:\Users\HarshC\AppData\Roaming\npm\node_modules\npm\node_modules\bluebird\js\release\promise_array.js:126:19)
6 verbose cwd C:\users\HarshC\codelabs-nodejs\level2
7 verbose Windows_NT 10.0.16299
8 verbose argv "C:\Program Files\nodejs\node.exe" "C:\Users\HarshC\AppData\Roaming\npm\node_modules\npm\bin\npm-cli.js" "audit"
9 verbose node v6.11.2
10 verbose npm v6.0.1
11 error code EAUDITNOPJSON
12 error audit No package.json found: Cannot audit a project without a package.json
13 verbose exit [ 1, true ]

when I check the folders using $ dir I get:
codelab-level-one.zip firebase.json functions`

but when i navigate to the folder I do see package.json

Please help I do not know what to do

[laurenzlong]

@HarshHC You have to run "npm install" while inside your functions folder

[gerhardcit]

@laurenzlong , If I search for "Error parsing triggers" in the github issues, there appears to a be long list of various problems related to this.
Is there away that parsing function can do better validation and provide better errors. That problem is underlying to most of the errors coming up, so that is not working well.
I've gone back through every version from 5.1.0 to 4.2.1 and cannot deploy a basic typescript functions project.
We are stuck with functions deploy.
Is there a guideline for node/npm versions and firebase-tools somewhere?

[thechenky]

Thank you for your feedback @gerhardcit! Unfortunately we cannot do better validation here because it's dependent on the user's code, so any issues in the global scope would show up as an error (we basically just wrap whatever npm throws).

Make sure that you compile the code if it's Typescript. I have a feeling there might be a problem with your pre-deploy hook not doing the compilation step. Can you check that you've set that up properly (use https://firebase.google.com/docs/functions/typescript as reference). If you still have issues and fixing pre-deploy hook did not work, please open another issue.

As far as suggestions on node/npm versions, we generally recommend you use a similar version you're deploying your functions in (6.14.0 for node6 https://cloud.google.com/functions/docs/concepts/nodejs-6-runtime or 8.11.1 for node8 https://cloud.google.com/functions/docs/concepts/nodejs-8-runtime).

[thechenky]

@Flypex as others pointed out, make sure to have the dependency declared in your package.json file inside your functions directory, then run npm install . from the same directory. I'm going to close this out now. Please file another issue if you feel you're still getting errors. Thanks everyone.