-
Notifications
You must be signed in to change notification settings - Fork 218
Update pubsub docs #1106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pubsub docs #1106
Conversation
57cea63 to
1b201dc
Compare
| * Interface representing a Google Cloud Pub/Sub message. | ||
| * | ||
| * @param data Payload of a Pub/Sub message. | ||
| * @param data - Payload of a Pub/Sub message. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
document the type param
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated... but there is likely a much better definition.
egilmorez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some thoughts, thanks!
Thank you!!! |
egilmorez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Update pubsub docs, clearing out existing warnings
d57e7f6 to
2946a93
Compare
Update pubsub docs, resolving warnings