Skip to content

Conversation

@TheIronDev
Copy link
Contributor

Update pubsub docs, resolving warnings

@TheIronDev TheIronDev requested review from colerogers and inlined May 9, 2022 17:01
@TheIronDev TheIronDev force-pushed the tystark.docs.pubsub branch 2 times, most recently from 57cea63 to 1b201dc Compare May 9, 2022 17:40
* Interface representing a Google Cloud Pub/Sub message.
*
* @param data Payload of a Pub/Sub message.
* @param data - Payload of a Pub/Sub message.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

document the type param

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated... but there is likely a much better definition.

@TheIronDev TheIronDev requested review from colerogers and inlined May 9, 2022 21:23
Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some thoughts, thanks!

@TheIronDev
Copy link
Contributor Author

Some thoughts, thanks!

Thank you!!!

Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@TheIronDev TheIronDev force-pushed the tystark.docs.pubsub branch from d57e7f6 to 2946a93 Compare May 10, 2022 15:33
@TheIronDev TheIronDev merged commit 2164615 into master May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants