Docs review for v2.https #1109
Merged
Docs review for v2.https #1109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inlined
reviewed
May 9, 2022
TheIronDev
reviewed
May 9, 2022
|
|
||
| /** | ||
| * Handles HTTPS requests. | ||
| */ |
egilmorez
reviewed
May 9, 2022
Contributor
egilmorez
left a comment
egilmorez
left a comment
There was a problem hiding this comment.
Some thoughts Joe, thanks!
Kudos for staging and eyeballing the lists (I'm assuming you did that).
Contributor
Author
|
@egilmorez Addressed feedback. I haven't staged the list changes yet - I just manually reviewed the MD files and verified that the dcogen added linebreaks where expected. I'll take a crack at that now - however, my desktop is not in working condition RN so I may run into some issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reviewed the staged HTTPS docs, and found +fixed the following issues:
Formatting Issues:
Missing descriptions:
onCall
onRequest
httpError.toJson - Added a brief description
https.HttpsOptions.cors - Added an explanation of what this option does with various types - please double check this to make sure I'm correct
request.rawBody - added a brief description