Handle Firestore timestamp values with precision to the second #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inlined
requested changes
Oct 23, 2017
src/encoder.ts
Outdated
| nanoString = '000000000'; | ||
| } else { | ||
| nanoString = timeString.substring(20, timeString.length - 1); | ||
| nanoString += _.reduce(new Array(9 - nanoString.length), i => {return i + '0';}, ''); |
Member
There was a problem hiding this comment.
Woah... String -> array -> reduce -> parseInt? It may be the c programmer in me, but string manipulation of numbers feels really wonky.
why not something like
let nanos: 0;
if (timeString.length > 20) {
const nanoString = timeString.substring(20, timeString.length - 1);
const trailingZeros = 9 - nanoString.length;
nanos = parseInt(nanoString, 10) * Math.pow(10, trailingZeroes);
}
Contributor
Author
|
@inlined That is way cleaner, thank you. |
inlined
approved these changes
Oct 23, 2017
src/encoder.ts
Outdated
| } | ||
| let proto = { | ||
|
|
||
| return { |
Member
There was a problem hiding this comment.
You can also say return {seconds, nanos}
It felt weird to me at first, but it starts to feel pretty natural and expressive. It also encourages you to use variable names as they'll appear in your return values/API calls which tends to lead to more readable code.
Contributor
Author
There was a problem hiding this comment.
nifty! thanks for the tip!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes bug where timestamp values that didn't have millisecond or nanosecond precision resulted in "Invalid date" when event.data.data() is called.
Code sample