Skip to content

Handle Firestore timestamp values with precision to the second #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 23, 2017
Merged

Handle Firestore timestamp values with precision to the second #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7b735bf
Add test
Oct 23, 2017
0cfa512
Handle timestamp values with precision to the second
Oct 23, 2017
50a3a1b
Revise according to review comments
Oct 23, 2017
4298295
small change
Oct 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion spec/providers/firestore.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ describe('Firestore Functions', () => {
expect(snapshot.data()['referenceVal'].path).to.equal('doc1/id');
});

it('should parse timestamp values', () => {
it('should parse timestamp values with precision to the millisecond', () => {
let raw = constructValue({
'timestampVal': {
'timestampValue': '2017-06-13T00:58:40.349Z',
Expand All @@ -307,6 +307,19 @@ describe('Firestore Functions', () => {
expect(snapshot.data()).to.deep.equal({'timestampVal': new Date('2017-06-13T00:58:40.349Z')});
});

it('should parse timestamp values with precision to the second', () => {
let raw = constructValue({
'timestampVal': {
'timestampValue': '2017-06-13T00:58:40Z',
},
});
let snapshot = firestore.dataConstructor({
data: { value: raw },
});
expect(snapshot.data()).to.deep.equal({'timestampVal': new Date('2017-06-13T00:58:40Z')});

});

it('should parse binary values', () => {
// Format defined in https://developers.google.com/discovery/v1/type-format
let raw = constructValue({
Expand Down
17 changes: 6 additions & 11 deletions src/encoder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,16 +26,11 @@ export function dateToTimestampProto(timeString) {
}
let date = new Date(timeString);
let seconds = Math.floor(date.getTime() / 1000);
let nanoString = timeString.substring(20, timeString.length - 1);

if (nanoString.length === 3) {
nanoString = `${nanoString}000000`;
} else if (nanoString.length === 6) {
nanoString = `${nanoString}000`;
let nanos = 0;
if (timeString.length > 20) {
const nanoString = timeString.substring(20, timeString.length - 1);
const trailingZeroes = 9 - nanoString.length;
nanos = parseInt(nanoString, 10) * Math.pow(10, trailingZeroes);
}
let proto = {
seconds: seconds,
nanos: parseInt(nanoString, 10),
};
return proto;
return { seconds, nanos };
};