Skip to content

Conversation

@laurenzlong
Copy link
Contributor

Description

Code sample

changelog.txt Outdated
@@ -1,0 +1,2 @@
important - `firebase-admin` peer dependency is now v5.5.0. Must update `firebase-admin` version inside of your function's directory's `package.json` and re-install locally.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

function's --> functions?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

changelog.txt Outdated
@@ -1,0 +1,2 @@
important - `firebase-admin` peer dependency is now v5.5.0. Must update `firebase-admin` version inside of your function's directory's `package.json` and re-install locally.
changed - For Firestore events where no previous data exists, event.data.previous is no longer null, it is always a Firebase DocumentSnapshot. event.data.previous.exists will be false if there is no previous data. (This change was previously released in v4.7.4, and reverted in v4.7.5.)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v4.7.4/5 --> v0.7.4/5

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

Copy link
Member

@inlined inlined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT about adding a feature that turns mismatched peer dependencies into an error?

changelog.txt Outdated
@@ -1,0 +1,2 @@
important - `firebase-admin` peer dependency is now v5.5.0. Must update `firebase-admin` version inside of your function's directory's `package.json` and re-install locally.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@inlined inlined assigned inlined and laurenzlong and unassigned inlined Dec 26, 2017
@laurenzlong laurenzlong merged commit b745f8c into master Jan 3, 2018
@laurenzlong laurenzlong deleted the laurenzlong-patch-3 branch May 25, 2018 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants