From 9e8901083a3a41e9a75d9ff485bea18eec2d57d6 Mon Sep 17 00:00:00 2001 From: Diana Tkachenko Date: Mon, 3 Jun 2019 13:35:19 -0700 Subject: [PATCH 1/2] add new region support --- spec/function-builder.spec.ts | 4 ++++ src/function-builder.ts | 2 ++ 2 files changed, 6 insertions(+) diff --git a/spec/function-builder.spec.ts b/spec/function-builder.spec.ts index 615d9fe9c..24244c00a 100644 --- a/spec/function-builder.spec.ts +++ b/spec/function-builder.spec.ts @@ -56,8 +56,10 @@ describe('FunctionBuilder', () => { .region( 'us-central1', 'us-east1', + 'us-east4', 'europe-west1', 'europe-west2', + 'europe-west4', 'asia-east2', 'asia-northeast1' ) @@ -67,8 +69,10 @@ describe('FunctionBuilder', () => { expect(fn.__trigger.regions).to.deep.equal([ 'us-central1', 'us-east1', + 'us-east4', 'europe-west1', 'europe-west2', + 'europe-west4', 'asia-east2', 'asia-northeast1', ]); diff --git a/src/function-builder.ts b/src/function-builder.ts index 42de739eb..a0bb40ed4 100644 --- a/src/function-builder.ts +++ b/src/function-builder.ts @@ -40,8 +40,10 @@ import { CloudFunction, EventContext, Schedule } from './cloud-functions'; const SUPPORTED_REGIONS = [ 'us-central1', 'us-east1', + 'us-east4', 'europe-west1', 'europe-west2', + 'europe-west4', 'asia-east2', 'asia-northeast1', ]; From 20284fbcb96ef9cc84d37973a054059734f4224e Mon Sep 17 00:00:00 2001 From: Diana Tkachenko Date: Tue, 2 Jul 2019 10:30:34 -0700 Subject: [PATCH 2/2] remove europe-west4 as it's delayed, update changelog --- changelog.txt | 1 + spec/function-builder.spec.ts | 2 -- src/function-builder.ts | 1 - 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/changelog.txt b/changelog.txt index e69de29bb..1385ce18b 100644 --- a/changelog.txt +++ b/changelog.txt @@ -0,0 +1 @@ +feature - Adds region support for us-east4. \ No newline at end of file diff --git a/spec/function-builder.spec.ts b/spec/function-builder.spec.ts index 24244c00a..6038898dc 100644 --- a/spec/function-builder.spec.ts +++ b/spec/function-builder.spec.ts @@ -59,7 +59,6 @@ describe('FunctionBuilder', () => { 'us-east4', 'europe-west1', 'europe-west2', - 'europe-west4', 'asia-east2', 'asia-northeast1' ) @@ -72,7 +71,6 @@ describe('FunctionBuilder', () => { 'us-east4', 'europe-west1', 'europe-west2', - 'europe-west4', 'asia-east2', 'asia-northeast1', ]); diff --git a/src/function-builder.ts b/src/function-builder.ts index a0bb40ed4..83e9a00b0 100644 --- a/src/function-builder.ts +++ b/src/function-builder.ts @@ -43,7 +43,6 @@ const SUPPORTED_REGIONS = [ 'us-east4', 'europe-west1', 'europe-west2', - 'europe-west4', 'asia-east2', 'asia-northeast1', ];